Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1287863004: Test scaling for small images (Closed)

Created:
5 years, 4 months ago by msarett
Modified:
5 years, 4 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Test scaling for small images We don't want to test small images on Gold because they are not interested to look at. Instead, I wrote a unit test to verify that scaling small images does not cause crashes. BUG=skia: Committed: https://skia.googlesource.com/skia/+/b32758a72fa582a5e40623ffe145727820343909

Patch Set 1 : #

Total comments: 1

Patch Set 2 : All the extra scales don't improve the test #

Patch Set 3 : Fixed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -3 lines) Patch
M dm/DMSrcSink.cpp View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M include/codec/SkCodec.h View 1 chunk +11 lines, -0 lines 0 comments Download
M tests/CodexTest.cpp View 1 3 chunks +21 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 1188223002 Patch 1

Messages

Total messages: 9 (4 generated)
msarett
Hopefully this will make the triaging a little easier :)
5 years, 4 months ago (2015-08-18 19:56:53 UTC) #3
djsollen
https://codereview.chromium.org/1287863004/diff/20001/dm/DMSrcSink.cpp File dm/DMSrcSink.cpp (right): https://codereview.chromium.org/1287863004/diff/20001/dm/DMSrcSink.cpp#newcode127 dm/DMSrcSink.cpp:127: return Error::Nonfatal("Scaling very small is uninteresting."); small images
5 years, 4 months ago (2015-08-18 20:03:16 UTC) #4
djsollen
lgtm
5 years, 4 months ago (2015-08-18 20:03:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287863004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287863004/60001
5 years, 4 months ago (2015-08-18 20:05:44 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 20:22:49 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:60001) as
https://skia.googlesource.com/skia/+/b32758a72fa582a5e40623ffe145727820343909

Powered by Google App Engine
This is Rietveld 408576698