Add CompileInfo::GetDebugName()

Add CompileInfo::GetDebugName()

Replaces all instances of the code which computed the debug
name of a stub or function with calls to CompileInfo::GetDebugName instead.

Also:
  - Removes useless parameter on CodeStub::GetMajorName
  - Removes FakeStubForTesting since it is no longer required
  - Adds CompileInfo::ShouldEnsureSpaceForLazyDeopt() to replace unclear calls to IsStub().

Committed: https://crrev.com/53ac9fe8f9fa57f0f6d2960d5de92b9236bd871a
Cr-Commit-Position: refs/heads/master@{#30324}

[rmcilroy, 2015-08-18 11:56:45]

Patchset #1 (id:1) has been deleted

[rmcilroy, 2015-08-18 11:56:52]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-18 11:56:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1297203002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1297203002/20001

[rmcilroy, 2015-08-18 11:59:10]

rmcilroy@chromium.org changed reviewers:
+ titzer@chromium.org

[rmcilroy, 2015-08-18 11:59:10]

These are the changes needed to print out bytecode handlers to the turbofan
visualizer. I'm happy to do this differently if you need similar things for WASM
(e.g., you were talking about using an enum for the pipeline steps taken in
today's meeting).

PTAL, thanks.

[commit-bot: I haz the power, 2015-08-18 12:09:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-18 12:09:24]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/8664)

[rmcilroy, 2015-08-18 13:11:20]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-18 13:11:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1297203002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1297203002/40001

[commit-bot: I haz the power, 2015-08-18 13:35:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-18 13:35:48]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2015-08-21 13:26:04]

Updated to replace "!info->IsStub() && !info->IsBytecodeHandler()" with a new
ShouldEnsureSpaceForLazyDeopt() function based on offline discussion with Danno.


Ben, could you PTAL? Thanks.

[rmcilroy, 2015-08-21 13:26:15]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-21 13:26:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1297203002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1297203002/60001

[titzer, 2015-08-21 13:37:21]

https://codereview.chromium.org/1297203002/diff/60001/src/codegen.cc
File src/codegen.cc (right):

https://codereview.chromium.org/1297203002/diff/60001/src/codegen.cc#newcode160
src/codegen.cc:160: info->IsStub() || info->IsBytecodeHandler();
Here too

https://codereview.chromium.org/1297203002/diff/60001/src/compiler.h
File src/compiler.h (right):

https://codereview.chromium.org/1297203002/diff/60001/src/compiler.h#newcode441
src/compiler.h:441: BYTECODE_HANDLER
Do we really need a new mode? What does it control?

https://codereview.chromium.org/1297203002/diff/60001/src/compiler.h#newcode467
src/compiler.h:467: interpreter::Bytecode bytecode_;
AFAICT this is only used for debugging purposes in printing to the log file. Can
we find another way to handle that without adding more stuff to the (already
bloated) compilation info?

https://codereview.chromium.org/1297203002/diff/60001/src/compiler/code-gener...
File src/compiler/code-generator.cc (right):

https://codereview.chromium.org/1297203002/diff/60001/src/compiler/code-gener...
src/compiler/code-generator.cc:196: if (!info->IsStub() &&
!info->IsBytecodeHandler()) {
Missed this one.

[commit-bot: I haz the power, 2015-08-21 13:50:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-21 13:50:58]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2015-08-21 16:31:29]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-21 16:31:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1297203002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1297203002/80001

[rmcilroy, 2015-08-21 16:41:05]

rmcilroy@chromium.org changed reviewers:
+ yangguo@chromium.org

[rmcilroy, 2015-08-21 16:41:06]

+Yang for serializer/ review.

Ben: I've reworked things to have a GetDebugName on CompilerInfo. I've replaced
all the copy/pasted code which got the debug name from the CompilerInfo with a
call to this new function and have done a couple of other cleanups (removing a
useless parameter on MajorName() and removing FakeStubForTesting which is no
longer required).

I've taken out all of the changes required for interpreter verification from
this CL (I'll land that as a followup) and this CL should now only be a refactor
CL with no functional changes. PTAL, thanks.

https://codereview.chromium.org/1297203002/diff/60001/src/codegen.cc
File src/codegen.cc (right):

https://codereview.chromium.org/1297203002/diff/60001/src/codegen.cc#newcode160
src/codegen.cc:160: info->IsStub() || info->IsBytecodeHandler();
On 2015/08/21 13:37:21, titzer wrote:
> Here too

Removed this (it's not about lazy deopt, so didn't replace it with
ShouldEnsureSpaceForLazyDeopt()).

https://codereview.chromium.org/1297203002/diff/60001/src/compiler.h
File src/compiler.h (right):

https://codereview.chromium.org/1297203002/diff/60001/src/compiler.h#newcode441
src/compiler.h:441: BYTECODE_HANDLER
On 2015/08/21 13:37:21, titzer wrote:
> Do we really need a new mode? What does it control?

Removed this mode and replaced it's need with debug_name.

https://codereview.chromium.org/1297203002/diff/60001/src/compiler.h#newcode467
src/compiler.h:467: interpreter::Bytecode bytecode_;
On 2015/08/21 13:37:21, titzer wrote:
> AFAICT this is only used for debugging purposes in printing to the log file.
Can
> we find another way to handle that without adding more stuff to the (already
> bloated) compilation info?

Done with GetDebugName as discussed.

https://codereview.chromium.org/1297203002/diff/60001/src/compiler/code-gener...
File src/compiler/code-generator.cc (right):

https://codereview.chromium.org/1297203002/diff/60001/src/compiler/code-gener...
src/compiler/code-generator.cc:196: if (!info->IsStub() &&
!info->IsBytecodeHandler()) {
On 2015/08/21 13:37:21, titzer wrote:
> Missed this one.

Done.

[commit-bot: I haz the power, 2015-08-21 16:43:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-21 16:43:32]

Dry run: Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/8944)

[rmcilroy, 2015-08-21 17:20:13]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-21 17:20:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1297203002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1297203002/100001

[commit-bot: I haz the power, 2015-08-21 17:33:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-21 17:33:05]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/8841)

[rmcilroy, 2015-08-21 23:42:47]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-21 23:43:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1297203002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1297203002/120001

[commit-bot: I haz the power, 2015-08-22 00:08:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-22 00:08:44]

Dry run: This issue passed the CQ dry run.

[Yang, 2015-08-24 07:04:22]

On 2015/08/22 00:08:44, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

serializer change lgtm.

[titzer, 2015-08-24 09:36:30]

lgtm

[rmcilroy, 2015-08-24 09:51:57]

The CQ bit was checked by rmcilroy@chromium.org

[commit-bot: I haz the power, 2015-08-24 09:52:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1297203002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1297203002/120001

[commit-bot: I haz the power, 2015-08-24 10:23:45]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2015-08-24 10:24:01]

Patchset 6 (id:??) landed as
https://crrev.com/53ac9fe8f9fa57f0f6d2960d5de92b9236bd871a
Cr-Commit-Position: refs/heads/master@{#30324}