Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: src/code-stubs.h

Issue 1297203002: Add CompileInfo::GetDebugName() (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@interpreter_immed_bytecodes
Patch Set: Fix test crash Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/code-stubs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index c7de00b858a2b0447f512d1d83f9579a2f22e955..2e8f1076be10c3e25ca73ff011174be1f94e932d 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -199,7 +199,7 @@ class CodeStub BASE_EMBEDDED {
static uint32_t NoCacheKey() { return MajorKeyBits::encode(NoCache); }
- static const char* MajorName(Major major_key, bool allow_unknown_keys);
+ static const char* MajorName(Major major_key);
explicit CodeStub(Isolate* isolate) : minor_key_(0), isolate_(isolate) {}
virtual ~CodeStub() {}
@@ -316,29 +316,6 @@ class CodeStub BASE_EMBEDDED {
};
-// TODO(svenpanne) This class is only used to construct a more or less sensible
-// CompilationInfo for testing purposes, basically pretending that we are
-// currently compiling some kind of code stub. Remove this when the pipeline and
-// testing machinery is restructured in such a way that we don't have to come up
-// with a CompilationInfo out of thin air, although we only need a few parts of
-// it.
-struct FakeStubForTesting : public CodeStub {
- explicit FakeStubForTesting(Isolate* isolate) : CodeStub(isolate) {}
-
- // Only used by pipeline.cc's GetDebugName in DEBUG mode.
- Major MajorKey() const override { return CodeStub::NoCache; }
-
- CallInterfaceDescriptor GetCallInterfaceDescriptor() const override {
- return ContextOnlyDescriptor(isolate());
- }
-
- Handle<Code> GenerateCode() override {
- UNREACHABLE();
- return Handle<Code>();
- }
-};
-
-
#define DEFINE_CODE_STUB_BASE(NAME, SUPER) \
public: \
NAME(uint32_t key, Isolate* isolate) : SUPER(key, isolate) {} \
« no previous file with comments | « no previous file | src/code-stubs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698