|
|
Revert of aura: Require explicit ownership of the Env instance. (patchset #7 id:120001 of https://codereview.chromium.org/1293013002/ )
Reason for revert:
This broke mandoline --enable-multiprocess on Linux:
[0818/183133:FATAL:x11_event_source.cc(80)] Check failed: display_.
Original issue's description:
> aura: Require explicit ownership of the Env instance.
>
> Notable changes:
> . Change aura::Env::CreateInstance() to return a scoped_ptr<> to the aura::Env instance,
> so that there's a clear owner of the instance, and random code can no longer destroy
> it.
> . Make aura::Env::CreateInstance() fail if more than one instance is attempted to be
> created.
> . Remove the boolean parameter to aura::Env::CreateInstance(), since that is no longer
> necessary, and always create a PlatformEventSource instance (if one hasn't already
> been created).
> . BrowserMainLoop takes care of creating/destroying the aura::Env instance. So the
> various BrowserMainParts implementations no longer need to do that.
>
> BUG=none
> TBR=ben@chromium.org as top-level owner for API change updates.
>
> Committed: https://crrev.com/535b77f94d63736b21583c76e2dbf1f2a75e6377
> Cr-Commit-Position: refs/heads/master@{#344037}
TBR=sky@chromium.org,ben@chromium.org,sadrul@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none
Committed: https://crrev.com/58ea5a7a5598d0709aaf3a3b7cbd0b850b860b5c
Cr-Commit-Position: refs/heads/master@{#344058}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+76 lines, -95 lines) |
Patch |
 |
M |
ash/shell/content_client/shell_browser_main_parts.cc
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
ash/test/ash_interactive_ui_test_base.h
|
View
|
|
2 chunks |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
ash/test/ash_interactive_ui_test_base.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
ash/test/test_suite.h
|
View
|
|
2 chunks |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
ash/test/test_suite.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/test/base/view_event_test_platform_part_ash.cc
|
View
|
|
2 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/test/base/view_event_test_platform_part_chromeos.cc
|
View
|
|
3 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chromecast/browser/cast_browser_main_parts.cc
|
View
|
|
2 chunks |
+5 lines, -0 lines |
0 comments
|
Download
|
 |
M |
content/browser/browser_main_loop.h
|
View
|
|
2 chunks |
+0 lines, -10 lines |
0 comments
|
Download
|
 |
M |
content/browser/browser_main_loop.cc
|
View
|
|
3 chunks |
+5 lines, -3 lines |
0 comments
|
Download
|
 |
M |
content/public/test/unittest_test_suite.h
|
View
|
|
2 chunks |
+0 lines, -9 lines |
0 comments
|
Download
|
 |
M |
content/public/test/unittest_test_suite.cc
|
View
|
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
content/shell/browser/shell_aura.cc
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
content/shell/browser/shell_views.cc
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
mandoline/ui/aura/aura_init.h
|
View
|
|
2 chunks |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
mandoline/ui/aura/aura_init.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
ui/aura/bench/bench_main.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
ui/aura/demo/demo_main.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
ui/aura/env.h
|
View
|
|
2 chunks |
+9 lines, -4 lines |
0 comments
|
Download
|
 |
M |
ui/aura/env.cc
|
View
|
|
3 chunks |
+16 lines, -13 lines |
0 comments
|
Download
|
 |
M |
ui/aura/test/aura_test_helper.h
|
View
|
|
2 chunks |
+1 line, -5 lines |
0 comments
|
Download
|
 |
M |
ui/aura/test/aura_test_helper.cc
|
View
|
|
3 chunks |
+8 lines, -4 lines |
0 comments
|
Download
|
 |
M |
ui/aura/test/run_all_unittests.cc
|
View
|
|
1 chunk |
+2 lines, -3 lines |
0 comments
|
Download
|
 |
M |
ui/views/examples/examples_main.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
ui/views/run_all_unittests.cc
|
View
|
|
1 chunk |
+2 lines, -5 lines |
0 comments
|
Download
|
 |
M |
ui/views_content_client/views_content_client_main_parts_aura.cc
|
View
|
|
2 chunks |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
M |
ui/views_content_client/views_content_client_main_parts_desktop_aura.cc
|
View
|
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
ui/wm/test/run_all_unittests.cc
|
View
|
|
2 chunks |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
ui/wm/test/wm_test_helper.cc
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
Total messages: 4 (0 generated)
|