content/public/test/unittest_test_suite.cc - Issue 1297173003: Revert of aura: Require explicit ownership of the Env instance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/unittest_test_suite.cc

Issue 1297173003: Revert of aura: Require explicit ownership of the Env instance. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/test/unittest_test_suite.cc

diff --git a/content/public/test/unittest_test_suite.cc b/content/public/test/unittest_test_suite.cc

index 1a717701c0ab7f248034db91617088f110b47bfe..573838aad9ba45d450c3eb4cddeb9e60f7c858bb 100644

--- a/content/public/test/unittest_test_suite.cc

+++ b/content/public/test/unittest_test_suite.cc

@@ -30,7 +30,8 @@

#endif

#if defined(USE_AURA)

DCHECK(!aura::Env::GetInstanceDontCreate());

- env_ = aura::Env::CreateInstance();

+ const bool create_event_source = true;

+ aura::Env::CreateInstance(create_event_source);

#endif

DCHECK(test_suite);

#if !defined(OS_IOS)

@@ -43,7 +44,7 @@

blink_test_support_.reset();

#endif

#if defined(USE_AURA)

- env_.reset();

+ aura::Env::DeleteInstance();

#endif

}

« no previous file with comments | « content/public/test/unittest_test_suite.h ('k') | content/shell/browser/shell_aura.cc » ('j') | no next file with comments »