Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Side by Side Diff: chromecast/browser/cast_browser_main_parts.cc

Issue 1297173003: Revert of aura: Require explicit ownership of the Env instance. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromecast/browser/cast_browser_main_parts.h" 5 #include "chromecast/browser/cast_browser_main_parts.h"
6 6
7 #include <string> 7 #include <string>
8 #if !defined(OS_ANDROID) 8 #if !defined(OS_ANDROID)
9 #include <signal.h> 9 #include <signal.h>
10 #include <sys/prctl.h> 10 #include <sys/prctl.h>
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 #include "components/crash/browser/crash_dump_manager_android.h" 53 #include "components/crash/browser/crash_dump_manager_android.h"
54 #include "media/base/android/media_client_android.h" 54 #include "media/base/android/media_client_android.h"
55 #include "net/android/network_change_notifier_factory_android.h" 55 #include "net/android/network_change_notifier_factory_android.h"
56 #else 56 #else
57 #include "chromecast/browser/media/cast_browser_cdm_factory.h" 57 #include "chromecast/browser/media/cast_browser_cdm_factory.h"
58 #include "chromecast/net/network_change_notifier_factory_cast.h" 58 #include "chromecast/net/network_change_notifier_factory_cast.h"
59 #endif 59 #endif
60 60
61 #if defined(USE_AURA) 61 #if defined(USE_AURA)
62 #include "chromecast/graphics/cast_screen.h" 62 #include "chromecast/graphics/cast_screen.h"
63 #include "ui/aura/env.h"
63 #include "ui/gfx/screen.h" 64 #include "ui/gfx/screen.h"
64 #endif 65 #endif
65 66
66 namespace { 67 namespace {
67 68
68 #if !defined(OS_ANDROID) 69 #if !defined(OS_ANDROID)
69 int kSignalsToRunClosure[] = { SIGTERM, SIGINT, }; 70 int kSignalsToRunClosure[] = { SIGTERM, SIGINT, };
70 71
71 // Closure to run on SIGTERM and SIGINT. 72 // Closure to run on SIGTERM and SIGINT.
72 base::Closure* g_signal_closure = NULL; 73 base::Closure* g_signal_closure = NULL;
(...skipping 309 matching lines...) Expand 10 before | Expand all | Expand 10 after
382 383
383 void CastBrowserMainParts::PostMainMessageLoopRun() { 384 void CastBrowserMainParts::PostMainMessageLoopRun() {
384 #if defined(OS_ANDROID) 385 #if defined(OS_ANDROID)
385 // Android does not use native main MessageLoop. 386 // Android does not use native main MessageLoop.
386 NOTREACHED(); 387 NOTREACHED();
387 #else 388 #else
388 cast_browser_process_->cast_service()->Finalize(); 389 cast_browser_process_->cast_service()->Finalize();
389 cast_browser_process_->metrics_service_client()->Finalize(); 390 cast_browser_process_->metrics_service_client()->Finalize();
390 cast_browser_process_.reset(); 391 cast_browser_process_.reset();
391 392
393 #if defined(USE_AURA)
394 aura::Env::DeleteInstance();
395 #endif
396
392 DeregisterKillOnAlarm(); 397 DeregisterKillOnAlarm();
393 #endif 398 #endif
394 399
395 // Finalize CastMediaShlib on media thread to ensure it's not accessed 400 // Finalize CastMediaShlib on media thread to ensure it's not accessed
396 // after Finalize. 401 // after Finalize.
397 media::MediaMessageLoop::GetTaskRunner()->PostTask( 402 media::MediaMessageLoop::GetTaskRunner()->PostTask(
398 FROM_HERE, base::Bind(&media::CastMediaShlib::Finalize)); 403 FROM_HERE, base::Bind(&media::CastMediaShlib::Finalize));
399 } 404 }
400 405
401 } // namespace shell 406 } // namespace shell
402 } // namespace chromecast 407 } // namespace chromecast
OLDNEW
« no previous file with comments | « chrome/test/base/view_event_test_platform_part_chromeos.cc ('k') | content/browser/browser_main_loop.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698