Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/widget/ToolbarProgressBarTest.java

Issue 1297073004: Fix various errorprone warnings and errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove third_party/mojo/src change. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/widget/ToolbarProgressBarTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/widget/ToolbarProgressBarTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/widget/ToolbarProgressBarTest.java
index 8407d32c1e1dc02add810aacbb885582d9805529..b8c6572a6009e1a1d0d700bbe9744269d9f11719 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/widget/ToolbarProgressBarTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/widget/ToolbarProgressBarTest.java
@@ -44,6 +44,7 @@ public class ToolbarProgressBarTest extends ChromeActivityTestCaseBase<ChromeAct
@MediumTest
@Restriction(RESTRICTION_TYPE_PHONE)
@SuppressFBWarnings({"WA_NOT_IN_LOOP", "UW_UNCOND_WAIT"})
+ @SuppressWarnings("WaitNotInLoop")
nyquist 2015/08/19 09:51:33 This seems dubious to me. Given the possible spuri
mikecase (-- gone --) 2015/08/19 23:15:08 Done
public void testProgressBarDisappearsAfterFastShowHide() throws InterruptedException {
// onAnimationEnd will be signaled on progress bar showing/hiding animation end.
final Object onAnimationEnd = new Object();

Powered by Google App Engine
This is Rietveld 408576698