chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProviderClient.java - Issue 1297073004: Fix various errorprone warnings and errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProviderClient.java

Issue 1297073004: Fix various errorprone warnings and errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove third_party/mojo/src change. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/android/javatests/src/org/chromium/base/ObserverListTest.java ('K') | « base/test/android/javatests/src/org/chromium/base/test/util/TestThread.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/WebappAuthenticatorTest.java » ('j') | chrome/android/javatests/src/org/chromium/chrome/browser/widget/ToolbarProgressBarTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProviderClient.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProviderClient.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProviderClient.java

index 77eef177ee3eb6973b19cd2adbb5369d297aa00e..c67a6fa4de47a70f41f4737e25ef08232e850c2c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProviderClient.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProviderClient.java

@@ -170,7 +170,7 @@ public class ChromeBrowserProviderClient {

return methodArgs;

}

- @SuppressWarnings("unchecked")

+ @SuppressWarnings({"unchecked", "TypeParameterUnusedInFormals"})

private static <T extends Object> T chromeBrowserProviderCall(Class returnType, String name,

nyquist 2015/08/19 09:51:33 Could this instead of suppressing the warning be C

mikecase (-- gone --) 2015/08/19 23:15:07 Done

Context context, Bundle args) {

android.util.Log.i(TAG, "before executing " + name + " call");