Issue 129693002: Properly launch the connectivity diagnostics app from the offline page

Issue 129693002: Properly launch the connectivity diagnostics app from the offline page (Closed)

Created:
6 years, 11 months ago by Zachary Kuznia

Modified:
6 years, 11 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, arv+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Properly launch the connectivity diagnostics app from the offline page BUG=332175 R=xiyuan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243717

Patch Set 1 #

Total comments: 2

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -6 lines)			Patch
M	chrome/browser/chromeos/offline/offline_load_page.cc	View	2 chunks	+9 lines, -0 lines	2 comments	Download
M	chrome/browser/resources/chromeos/neterror.js	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	chrome/browser/resources/chromeos/offline_net_load.html	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

xiyuan

lgtm https://codereview.chromium.org/129693002/diff/1/chrome/browser/chromeos/offline/offline_load_page.cc File chrome/browser/chromeos/offline/offline_load_page.cc (right): https://codereview.chromium.org/129693002/diff/1/chrome/browser/chromeos/offline/offline_load_page.cc#newcode145 chrome/browser/chromeos/offline/offline_load_page.cc:145: GetInstalledExtension("kodldpbjkkmmnilagfdheibampofhaom"); nit: add the app id to extension_constants.h|cc.

6 years, 11 months ago (2014-01-08 23:17:39 UTC) #2

Zachary Kuznia

https://codereview.chromium.org/129693002/diff/1/chrome/browser/chromeos/offline/offline_load_page.cc File chrome/browser/chromeos/offline/offline_load_page.cc (right): https://codereview.chromium.org/129693002/diff/1/chrome/browser/chromeos/offline/offline_load_page.cc#newcode145 chrome/browser/chromeos/offline/offline_load_page.cc:145: GetInstalledExtension("kodldpbjkkmmnilagfdheibampofhaom"); On 2014/01/08 23:17:40, xiyuan wrote: > nit: add ...

6 years, 11 months ago (2014-01-08 23:23:51 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/129693002/1

6 years, 11 months ago (2014-01-08 23:34:55 UTC) #4

Zachary Kuznia

6 years, 11 months ago (2014-01-09 00:58:37 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r243717 (presubmit successful).

Expand Messages | Collapse Messages