Properly launch the connectivity diagnostics app from the offline page

chrome/browser/chromeos/offline/offline_load_page.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/offline/offline_load_page.h"
 
+#include "apps/launcher.h"
 #include "ash/shell.h"
 #include "ash/shell_delegate.h"
 #include "ash/system/tray/system_tray_delegate.h"
 #include "base/i18n/rtl.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
@@ skipping 113 matching lines @@
 
 void OfflineLoadPage::CommandReceived(const std::string& cmd) {
   std::string command(cmd);
   // The Jasonified response has quotes, remove them.
   if (command.length() > 1 && command[0] == '"') {
     command = command.substr(1, command.length() - 2);
   }
   // TODO(oshima): record action for metrics.
   if (command == "open_network_settings") {
     ash::Shell::GetInstance()->system_tray_delegate()->ShowNetworkSettings("");
+  } else if (command == "open_connectivity_diagnostics") {
+    Profile* profile = Profile::FromBrowserContext(
+        web_contents_->GetBrowserContext());
+    const extensions::Extension* extension = profile->GetExtensionService()->
+        GetInstalledExtension("kodldpbjkkmmnilagfdheibampofhaom");

[xiyuan, 2014/01/08 23:17:40]

nit: add the app id to extension_constants.h|cc.

[Zachary Kuznia, 2014/01/08 23:23:51]

Doing so in a follow up CL, as discussed.

+    apps::LaunchPlatformAppWithUrl(profile, extension, "",
+                                   GURL::EmptyGURL(), GURL::EmptyGURL());
+
   } else {
     LOG(WARNING) << "Unknown command:" << cmd;
   }
 }
 
 void OfflineLoadPage::NotifyBlockingPageComplete(bool proceed) {
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE, base::Bind(callback_, proceed));
 }
 
 void OfflineLoadPage::OnConnectionTypeChanged(
     net::NetworkChangeNotifier::ConnectionType type) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   const bool online = type != net::NetworkChangeNotifier::CONNECTION_NONE;
   DVLOG(1) << "ConnectionTypeObserver notification received: state="
            << (online ? "online" : "offline");
   if (online) {
     net::NetworkChangeNotifier::RemoveConnectionTypeObserver(this);
     interstitial_page_->Proceed();
   }
 }
 
 }  // namespace chromeos