Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1138)

Unified Diff: chrome/browser/chromeos/offline/offline_load_page.cc

Issue 129693002: Properly launch the connectivity diagnostics app from the offline page (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/neterror.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/offline/offline_load_page.cc
diff --git a/chrome/browser/chromeos/offline/offline_load_page.cc b/chrome/browser/chromeos/offline/offline_load_page.cc
index f78a07abd3a089a7e6b77d4314d72500d81c9a38..84ee635b8d640e2c305d01a4221c3f04eab50a01 100644
--- a/chrome/browser/chromeos/offline/offline_load_page.cc
+++ b/chrome/browser/chromeos/offline/offline_load_page.cc
@@ -4,6 +4,7 @@
#include "chrome/browser/chromeos/offline/offline_load_page.h"
+#include "apps/launcher.h"
#include "ash/shell.h"
#include "ash/shell_delegate.h"
#include "ash/system/tray/system_tray_delegate.h"
@@ -137,6 +138,14 @@ void OfflineLoadPage::CommandReceived(const std::string& cmd) {
// TODO(oshima): record action for metrics.
if (command == "open_network_settings") {
ash::Shell::GetInstance()->system_tray_delegate()->ShowNetworkSettings("");
+ } else if (command == "open_connectivity_diagnostics") {
+ Profile* profile = Profile::FromBrowserContext(
+ web_contents_->GetBrowserContext());
+ const extensions::Extension* extension = profile->GetExtensionService()->
+ GetInstalledExtension("kodldpbjkkmmnilagfdheibampofhaom");
xiyuan 2014/01/08 23:17:40 nit: add the app id to extension_constants.h|cc.
Zachary Kuznia 2014/01/08 23:23:51 Doing so in a follow up CL, as discussed.
+ apps::LaunchPlatformAppWithUrl(profile, extension, "",
+ GURL::EmptyGURL(), GURL::EmptyGURL());
+
} else {
LOG(WARNING) << "Unknown command:" << cmd;
}
« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/neterror.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698