Componentize proxy code from chrome/browser/net

components/proxy_config/proxy_prefs.h

Index: components/proxy_config/proxy_prefs.h
diff --git a/components/proxy_config/proxy_prefs.h b/components/proxy_config/proxy_prefs.h
index 8af504f5d14980a34108a3194b8428b716510c48..80ad758f71f225c73e2d78e9114b570f4b94d6a7 100644
--- a/components/proxy_config/proxy_prefs.h
+++ b/components/proxy_config/proxy_prefs.h
@@ -60,6 +60,7 @@ PROXY_CONFIG_EXPORT extern const char kAutoDetectProxyModeName[];
 PROXY_CONFIG_EXPORT extern const char kPacScriptProxyModeName[];
 PROXY_CONFIG_EXPORT extern const char kFixedServersProxyModeName[];
 PROXY_CONFIG_EXPORT extern const char kSystemProxyModeName[];
+PROXY_CONFIG_EXPORT extern const char kProxy[];

[droger, 2015/08/17 13:51:36]

For consistency this should be in the ProxyPrefs::prefs:: namespace.

Optionally move it to a separate file (proxy_config_pref_names.h), but maybe it
can stay here if the owner is OK with this. If you keep it here, maybe put it at
the top, right after the  namespace ProxyPrefs {.

namespace prefs {

PROXY_CONFIG_EXPORT extern const char kProxy[];

}  // namespace prefs

[Abhishek, 2015/08/19 08:30:49]

I think it would be good if we can move it to "proxy_config_pref_names.h".

I've kept it inside ProxyPrefs::prefs::kProxy namespace as suggested.

 
 PROXY_CONFIG_EXPORT bool IntToProxyMode(int in_value, ProxyMode* out_value);
 PROXY_CONFIG_EXPORT bool StringToProxyMode(const std::string& in_value,