components/proxy_config/proxy_prefs.cc - Issue 1296663003: Componentize proxy code from chrome/browser/net

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/proxy_config/proxy_prefs.cc

Issue 1296663003: Componentize proxy code from chrome/browser/net (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/proxy_config/proxy_prefs.cc

diff --git a/components/proxy_config/proxy_prefs.cc b/components/proxy_config/proxy_prefs.cc

index 215a45132b3ff13b550939155fe63862aec945f2..2759513c30659357c1a9e101d34f622f59190308 100644

--- a/components/proxy_config/proxy_prefs.cc

+++ b/components/proxy_config/proxy_prefs.cc

@@ -29,6 +29,7 @@ const char kAutoDetectProxyModeName[] = "auto_detect";

const char kPacScriptProxyModeName[] = "pac_script";

const char kFixedServersProxyModeName[] = "fixed_servers";

const char kSystemProxyModeName[] = "system";

+const char kProxy[] = "proxy";

droger 2015/08/17 13:51:36 Keep the original comment: // Preference to store

Abhishek 2015/08/19 08:30:49 Done.

bool IntToProxyMode(int in_value, ProxyMode* out_value) {

DCHECK(out_value);