Componentize proxy code from chrome/browser/net

components/proxy_config/proxy_prefs.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PROXY_CONFIG_PROXY_PREFS_H_
 #define COMPONENTS_PROXY_CONFIG_PROXY_PREFS_H_
 
 #include <string>
 
 #include "components/proxy_config/proxy_config_export.h"
@@ skipping 42 matching lines @@
   CONFIG_UNSET,
 };
 
 // Constants for string values used to specify the proxy mode through externally
 // visible APIs, e.g. through policy or the proxy extension API.
 PROXY_CONFIG_EXPORT extern const char kDirectProxyModeName[];
 PROXY_CONFIG_EXPORT extern const char kAutoDetectProxyModeName[];
 PROXY_CONFIG_EXPORT extern const char kPacScriptProxyModeName[];
 PROXY_CONFIG_EXPORT extern const char kFixedServersProxyModeName[];
 PROXY_CONFIG_EXPORT extern const char kSystemProxyModeName[];
+PROXY_CONFIG_EXPORT extern const char kProxy[];

[droger, 2015/08/17 13:51:36]

For consistency this should be in the ProxyPrefs::prefs:: namespace.

Optionally move it to a separate file (proxy_config_pref_names.h), but maybe it
can stay here if the owner is OK with this. If you keep it here, maybe put it at
the top, right after the  namespace ProxyPrefs {.

namespace prefs {

PROXY_CONFIG_EXPORT extern const char kProxy[];

}  // namespace prefs

[Abhishek, 2015/08/19 08:30:49]

I think it would be good if we can move it to "proxy_config_pref_names.h".

I've kept it inside ProxyPrefs::prefs::kProxy namespace as suggested.

 
 PROXY_CONFIG_EXPORT bool IntToProxyMode(int in_value, ProxyMode* out_value);
 PROXY_CONFIG_EXPORT bool StringToProxyMode(const std::string& in_value,
                                            ProxyMode* out_value);
 // Ownership of the return value is NOT passed to the caller.
 PROXY_CONFIG_EXPORT const char* ProxyModeToString(ProxyMode mode);
 PROXY_CONFIG_EXPORT std::string ConfigStateToDebugString(ConfigState state);
 
 }  // namespace ProxyPrefs
 
 #endif  // COMPONENTS_PROXY_CONFIG_PROXY_PREFS_H_