Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1296563002: Revert of Add dependency_manager initialization to binary_manager (Closed)

Created:
5 years, 4 months ago by binjin
Modified:
5 years, 4 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add dependency_manager initialization to binary_manager (patchset #10 id:230001 of https://codereview.chromium.org/1280903003/ ) Reason for revert: speculative reverts: break the XP bots http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/39447 Original issue's description: > Add dependency_manager initialization to binary_manager > > BUG=510231 > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect > > Committed: https://crrev.com/f592ba18312f43fe4186cc526db00960a1db0b48 > Cr-Commit-Position: refs/heads/master@{#343320} TBR=eakuefner@chromium.org,nednguyen@google.com,sullivan@chromium.org,dtu@chromium.org,dpranke@google.com,dpranke@chromium.org,aiolos@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=510231 Committed: https://crrev.com/de5b9964b9adfdd29c6d64c3e4dcf0ad1c487f82 Cr-Commit-Position: refs/heads/master@{#343360}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -185 lines) Patch
D tools/perf/core/project_config.py View 1 chunk +0 lines, -20 lines 0 comments Download
M tools/perf/run_benchmark View 1 chunk +6 lines, -2 lines 0 comments Download
M tools/perf/run_tests View 1 chunk +7 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/benchmark_runner.py View 4 chunks +6 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/core/exceptions.py View 1 chunk +0 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/internal/util/binary_manager.py View 1 chunk +0 lines, -45 lines 0 comments Download
D tools/telemetry/telemetry/internal/util/binary_manager_unittest.py View 1 chunk +0 lines, -84 lines 0 comments Download
M tools/telemetry/telemetry/testing/run_tests.py View 4 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
binjin
Created Revert of Add dependency_manager initialization to binary_manager
5 years, 4 months ago (2015-08-14 10:10:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296563002/1
5 years, 4 months ago (2015-08-14 10:10:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-14 10:11:10 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 10:11:49 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de5b9964b9adfdd29c6d64c3e4dcf0ad1c487f82
Cr-Commit-Position: refs/heads/master@{#343360}

Powered by Google App Engine
This is Rietveld 408576698