Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: tools/telemetry/telemetry/benchmark_runner.py

Issue 1296563002: Revert of Add dependency_manager initialization to binary_manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/run_tests ('k') | tools/telemetry/telemetry/core/exceptions.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/benchmark_runner.py
diff --git a/tools/telemetry/telemetry/benchmark_runner.py b/tools/telemetry/telemetry/benchmark_runner.py
index fdde6905697cdb8ecc8facac241ae4eed8555f89..eecb9458d71167fd755f8df30130ca1c303436c8 100644
--- a/tools/telemetry/telemetry/benchmark_runner.py
+++ b/tools/telemetry/telemetry/benchmark_runner.py
@@ -18,7 +18,6 @@
from telemetry import decorators
from telemetry.internal.browser import browser_finder
from telemetry.internal.browser import browser_options
-from telemetry.internal.util import binary_manager
from telemetry.internal.util import command_line
@@ -76,14 +75,17 @@
benchmark_dirs: A list of dirs containing benchmarks.
benchmark_aliases: A dict of name:alias string pairs to be matched against
exactly during benchmark selection.
- client_config: A path to a ProjectDependencies json file.
"""
def __init__(self, top_level_dir, benchmark_dirs=None,
- benchmark_aliases=None, client_config=None):
+ benchmark_aliases=None):
self._top_level_dir = top_level_dir
self._benchmark_dirs = benchmark_dirs or []
self._benchmark_aliases = benchmark_aliases or dict()
- self._client_config = client_config or ''
+
+ if benchmark_aliases:
+ self._benchmark_aliases = benchmark_aliases
+ else:
+ self._benchmark_aliases = {}
@property
def top_level_dir(self):
@@ -97,9 +99,6 @@
def benchmark_aliases(self):
return self._benchmark_aliases
- @property
- def client_config(self):
- return self._client_config
class Help(command_line.OptparseCommand):
"""Display help information about a command"""
@@ -409,8 +408,6 @@
else:
command = Run
- binary_manager.InitDependencyManager(environment.client_config)
-
# Parse and run the command.
parser = command.CreateParser()
command.AddCommandLineArgs(parser, environment)
« no previous file with comments | « tools/perf/run_tests ('k') | tools/telemetry/telemetry/core/exceptions.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698