Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: tools/telemetry/telemetry/internal/util/binary_manager_unittest.py

Issue 1296563002: Revert of Add dependency_manager initialization to binary_manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/internal/util/binary_manager_unittest.py
diff --git a/tools/telemetry/telemetry/internal/util/binary_manager_unittest.py b/tools/telemetry/telemetry/internal/util/binary_manager_unittest.py
deleted file mode 100644
index 2e52013daefa6262a4119d01bb86eaa1eb04c574..0000000000000000000000000000000000000000
--- a/tools/telemetry/telemetry/internal/util/binary_manager_unittest.py
+++ /dev/null
@@ -1,84 +0,0 @@
-# Copyright 2015 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-import os
-import unittest
-
-from telemetry.core import exceptions
-from telemetry.internal.util import binary_manager
-from telemetry.third_party import mock
-
-
-class BinaryManagerTest(unittest.TestCase):
- def setUp(self):
- self._old_bin_manager = binary_manager._dependency_manager
- binary_manager._dependency_manager = None
-
- def tearDown(self):
- binary_manager._dependency_manager = self._old_bin_manager
-
- def testInitializationNoEnvironmentConfig(self):
- manager = mock.MagicMock()
- binary_manager.dependency_manager = manager.dependency_manager
- expected = [mock.call.dependency_manager.DependencyManager(
- [binary_manager.TELEMETRY_PROJECT_CONFIG])]
- binary_manager.InitDependencyManager(None)
- self.assertEqual(manager.mock_calls, expected)
-
- def testInitializationWithEnvironmentConfig(self):
- environment_config = os.path.join('some', 'config', 'path')
- manager = mock.MagicMock()
- binary_manager.dependency_manager = manager.dependency_manager
- expected = [mock.call.dependency_manager.DependencyManager(
- [binary_manager.TELEMETRY_PROJECT_CONFIG, environment_config])]
- binary_manager.InitDependencyManager(environment_config)
- self.assertEqual(manager.mock_calls, expected)
-
- def testReinitialization(self):
- manager = mock.MagicMock()
- binary_manager.dependency_manager = manager.dependency_manager
- binary_manager.InitDependencyManager(None)
- self.assertRaises(exceptions.InitializationError,
- binary_manager.InitDependencyManager, None)
-
- def testFetchPathInitialized(self):
- manager = mock.MagicMock()
- binary_manager.dependency_manager = manager.dependency_manager
- binary_manager.support_binaries = manager.support_binaries
- expected = [mock.call.dependency_manager.DependencyManager(
- [binary_manager.TELEMETRY_PROJECT_CONFIG]),
- mock.call.support_binaries.FindPath('dep', 'plat', 'arch')]
- binary_manager.InitDependencyManager(None)
- binary_manager.FetchPath('dep', 'plat', 'arch')
- self.assertEqual(manager.mock_calls, expected)
- #TODO(aiolos): We should be switching over to using the dependency_manager
- #insead of the support binaries, and update the tests at that time.
-
- def testFetchPathUninitialized(self):
- manager = mock.MagicMock()
- binary_manager.dependency_manager = manager.dependency_manager
- binary_manager.support_binaries = manager.support_binaries
- self.assertRaises(exceptions.InitializationError,
- binary_manager.FetchPath, 'dep', 'plat', 'arch')
-
- def testLocalPathInitialized(self):
- manager = mock.MagicMock()
- binary_manager.dependency_manager = manager.dependency_manager
- binary_manager.support_binaries = manager.support_binaries
- expected = [mock.call.dependency_manager.DependencyManager(
- [binary_manager.TELEMETRY_PROJECT_CONFIG]),
- mock.call.support_binaries.FindLocallyBuiltPath('dep')]
- binary_manager.InitDependencyManager(None)
- binary_manager.LocalPath('dep', 'plat', 'arch')
- self.assertEqual(manager.mock_calls, expected)
- #TODO(aiolos): We should be switching over to using the dependency_manager
- #insead of the support binaries, and update the tests at that time.
-
- def testLocalPathUninitialized(self):
- manager = mock.MagicMock()
- binary_manager.dependency_manager = manager.dependency_manager
- binary_manager.support_binaries = manager.support_binaries
- self.assertRaises(exceptions.InitializationError,
- binary_manager.LocalPath, 'dep', 'plat', 'arch')
-
« no previous file with comments | « tools/telemetry/telemetry/internal/util/binary_manager.py ('k') | tools/telemetry/telemetry/testing/run_tests.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698