Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12965018: Move nested class GrDrawTarget::Caps out as GrDrawTargetCaps. (Closed)

Created:
7 years, 9 months ago by bsalomon
Modified:
7 years, 9 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com, jvanverth1
Visibility:
Public.

Description

Move nested class GrDrawTarget::Caps out as GrDrawTargetCaps. Pass caps to GrEffect::TestCreate() functions so that they can return effects that will work with the capabilities. Committed: https://code.google.com/p/skia/source/detail?r=8369

Patch Set 1 #

Patch Set 2 : #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -81 lines) Patch
M gyp/gpu.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/GrEffectUnitTest.h View 5 chunks +21 lines, -7 lines 4 comments Download
M src/effects/SkBicubicImageFilter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/SkMatrixConvolutionImageFilter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrBufferAllocPool.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M src/gpu/GrContext.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/GrDrawTarget.h View 5 chunks +3 lines, -52 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 5 chunks +6 lines, -5 lines 0 comments Download
A src/gpu/GrDrawTargetCaps.h View 1 1 chunk +58 lines, -0 lines 3 comments Download
M src/gpu/GrGpu.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrPathRendererChain.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrStencilAndCoverPathRenderer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrTexture.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/effects/GrCircleEdgeEffect.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/effects/GrEllipseEdgeEffect.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/effects/GrTextureDomainEffect.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bsalomon
Most files just add an unnamed const GrDrawTargetCaps& param to GrEffectSubclass::TestCreate.
7 years, 9 months ago (2013-03-25 17:57:51 UTC) #1
robertphillips
lgtm + nits https://codereview.chromium.org/12965018/diff/14001/include/gpu/GrEffectUnitTest.h File include/gpu/GrEffectUnitTest.h (right): https://codereview.chromium.org/12965018/diff/14001/include/gpu/GrEffectUnitTest.h#newcode67 include/gpu/GrEffectUnitTest.h:67: */ line up trailing '\'s? https://codereview.chromium.org/12965018/diff/14001/include/gpu/GrEffectUnitTest.h#newcode92 ...
7 years, 9 months ago (2013-03-25 18:11:36 UTC) #2
bsalomon
Committed patchset #2 manually as r8369 (presubmit successful).
7 years, 9 months ago (2013-03-25 18:19:21 UTC) #3
bsalomon
7 years, 9 months ago (2013-03-25 18:20:14 UTC) #4
Message was sent while issue was closed. 
https://codereview.chromium.org/12965018/diff/14001/include/gpu/GrEffectUnitT...
File include/gpu/GrEffectUnitTest.h (right):

https://codereview.chromium.org/12965018/diff/14001/include/gpu/GrEffectUnitT...
include/gpu/GrEffectUnitTest.h:67: */
On 2013/03/25 18:11:36, robertphillips wrote:
> line up trailing '\'s?

Done.

https://codereview.chromium.org/12965018/diff/14001/include/gpu/GrEffectUnitT...
include/gpu/GrEffectUnitTest.h:92: // its definitions will compile.
On 2013/03/25 18:11:36, robertphillips wrote:
> same here?

Done.

https://codereview.chromium.org/12965018/diff/14001/src/gpu/GrDrawTargetCaps.h
File src/gpu/GrDrawTargetCaps.h (right):

https://codereview.chromium.org/12965018/diff/14001/src/gpu/GrDrawTargetCaps....
src/gpu/GrDrawTargetCaps.h:8: 
On 2013/03/25 18:11:36, robertphillips wrote:
> double inclusion #ifdefs?

Done.

https://codereview.chromium.org/12965018/diff/14001/src/gpu/GrDrawTargetCaps....
src/gpu/GrDrawTargetCaps.h:8: 
On 2013/03/25 18:11:36, robertphillips wrote:
> double inclusion #ifdefs?

Done.

Powered by Google App Engine
This is Rietveld 408576698