Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1296483002: Split GrDrawBatch and GrVertexBatch into their own files (Closed)

Created:
5 years, 4 months ago by bsalomon
Modified:
5 years, 4 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Split GrDrawBatch and GrVertexBatch into their own files TBR=joshualitt@google.com Committed: https://skia.googlesource.com/skia/+/16b991390bb988b194a868ab8de66db4c21c7c13

Patch Set 1 #

Patch Set 2 : minor #

Patch Set 3 : Add new files to git #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -186 lines) Patch
M gm/convexpolyeffect.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/gpu.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAADistanceFieldPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAALinearizingConvexPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrImmediateDrawTarget.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrProcOptInfo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTargetCommands.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTargetCommands.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/GrTessellatingPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrAAFillRectBatch.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrAAStrokeRectBatch.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrBWFillRectBatch.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrBatch.h View 1 2 chunks +2 lines, -98 lines 0 comments Download
M src/gpu/batches/GrBatch.cpp View 2 chunks +0 lines, -66 lines 0 comments Download
M src/gpu/batches/GrDrawAtlasBatch.h View 1 chunk +1 line, -1 line 0 comments Download
A src/gpu/batches/GrDrawBatch.h View 1 2 1 chunk +49 lines, -0 lines 0 comments Download
A src/gpu/batches/GrDrawBatch.cpp View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
M src/gpu/batches/GrDrawVerticesBatch.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrStrokeRectBatch.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrTestBatch.h View 1 chunk +3 lines, -1 line 0 comments Download
A src/gpu/batches/GrVertexBatch.h View 1 2 1 chunk +71 lines, -0 lines 0 comments Download
A src/gpu/batches/GrVertexBatch.cpp View 1 2 1 chunk +51 lines, -0 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GrPorterDuffTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296483002/20001
5 years, 4 months ago (2015-08-13 21:43:45 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/2675) Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 4 months ago (2015-08-13 21:44:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296483002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296483002/40001
5 years, 4 months ago (2015-08-13 21:47:47 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 21:55:53 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/16b991390bb988b194a868ab8de66db4c21c7c13

Powered by Google App Engine
This is Rietveld 408576698