Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 1295633003: Cache Storage: replace assert_object_equals w/ assert_response_equals (Closed)

Created:
5 years, 4 months ago by jsbell
Modified:
5 years, 4 months ago
Reviewers:
jkarlin
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Cache Storage: replace assert_object_equals w/ assert_response_equals In web-platform-tests there's a move away from the generic (and fragile, buggy) assert_object_equals(). Upstream, the cache storage tests moved to dedicated assert_response_equals() (and friends); mirror that in Blink. R=jkarlin@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200998

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review feedback and rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -213 lines) Patch
M LayoutTests/PRESUBMIT.py View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/cachestorage/resources/test-helpers.js View 1 1 chunk +69 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/cachestorage/script-tests/cache-match.js View 1 11 chunks +11 lines, -11 lines 0 comments Download
M LayoutTests/http/tests/cachestorage/script-tests/cache-matchAll.js View 1 13 chunks +13 lines, -13 lines 0 comments Download
M LayoutTests/http/tests/cachestorage/script-tests/cache-put.js View 6 chunks +18 lines, -18 lines 0 comments Download
M LayoutTests/http/tests/cachestorage/script-tests/cache-storage-match.js View 4 chunks +8 lines, -8 lines 0 comments Download
M LayoutTests/http/tests/resources/testharness-helpers.js View 1 chunk +0 lines, -72 lines 0 comments Download
M LayoutTests/resources/testharness-helpers.js View 1 chunk +0 lines, -91 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jkarlin
lgtm https://codereview.chromium.org/1295633003/diff/1/LayoutTests/http/tests/cachestorage/resources/test-helpers.js File LayoutTests/http/tests/cachestorage/resources/test-helpers.js (right): https://codereview.chromium.org/1295633003/diff/1/LayoutTests/http/tests/cachestorage/resources/test-helpers.js#newcode43 LayoutTests/http/tests/cachestorage/resources/test-helpers.js:43: var header, actual_headers = [], expected_headers = []; ...
5 years, 4 months ago (2015-08-21 14:50:44 UTC) #1
jsbell
https://codereview.chromium.org/1295633003/diff/1/LayoutTests/http/tests/cachestorage/resources/test-helpers.js File LayoutTests/http/tests/cachestorage/resources/test-helpers.js (right): https://codereview.chromium.org/1295633003/diff/1/LayoutTests/http/tests/cachestorage/resources/test-helpers.js#newcode43 LayoutTests/http/tests/cachestorage/resources/test-helpers.js:43: var header, actual_headers = [], expected_headers = []; On ...
5 years, 4 months ago (2015-08-21 18:05:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1295633003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1295633003/20001
5 years, 4 months ago (2015-08-21 18:06:27 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 18:48:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200998

Powered by Google App Engine
This is Rietveld 408576698