Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: LayoutTests/http/tests/cachestorage/script-tests/cache-match.js

Issue 1295633003: Cache Storage: replace assert_object_equals w/ assert_response_equals (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Review feedback and rebased Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/http/tests/cachestorage/script-tests/cache-match.js
diff --git a/LayoutTests/http/tests/cachestorage/script-tests/cache-match.js b/LayoutTests/http/tests/cachestorage/script-tests/cache-match.js
index 4c9ce2d6ef2c5076c20d8dd398c3ccea7aebd79d..6f1cfac1ca123c099978185e62c749cf9aaf84bf 100644
--- a/LayoutTests/http/tests/cachestorage/script-tests/cache-match.js
+++ b/LayoutTests/http/tests/cachestorage/script-tests/cache-match.js
@@ -15,7 +15,7 @@ prepopulated_cache_test(simple_entries, function(cache, entries) {
prepopulated_cache_test(simple_entries, function(cache, entries) {
return cache.match(entries.a.request.url)
.then(function(result) {
- assert_object_equals_fixed(result, entries.a.response,
+ assert_response_equals(result, entries.a.response,
'Cache.match should match by URL.');
});
}, 'Cache.match with URL');
@@ -23,7 +23,7 @@ prepopulated_cache_test(simple_entries, function(cache, entries) {
prepopulated_cache_test(simple_entries, function(cache, entries) {
return cache.match(entries.a.request)
.then(function(result) {
- assert_object_equals_fixed(result, entries.a.response,
+ assert_response_equals(result, entries.a.response,
'Cache.match should match by Request.');
});
}, 'Cache.match with Request');
@@ -31,7 +31,7 @@ prepopulated_cache_test(simple_entries, function(cache, entries) {
prepopulated_cache_test(simple_entries, function(cache, entries) {
return cache.match(new Request(entries.a.request.url))
.then(function(result) {
- assert_object_equals_fixed(result, entries.a.response,
+ assert_response_equals(result, entries.a.response,
'Cache.match should match by Request.');
});
}, 'Cache.match with new Request');
@@ -40,7 +40,7 @@ prepopulated_cache_test(simple_entries, function(cache, entries) {
return cache.match(entries.a.request,
{ignoreSearch: true})
.then(function(result) {
- assert_object_in_array(
+ assert_response_in_array(
result,
[
entries.a.response,
@@ -57,7 +57,7 @@ prepopulated_cache_test(simple_entries, function(cache, entries) {
return cache.match(entries.a_with_query.request,
{ignoreSearch: true})
.then(function(result) {
- assert_object_in_array(
+ assert_response_in_array(
result,
[
entries.a.response,
@@ -72,7 +72,7 @@ prepopulated_cache_test(simple_entries, function(cache, entries) {
prepopulated_cache_test(simple_entries, function(cache, entries) {
return cache.match(entries.cat.request.url + '#mouse')
.then(function(result) {
- assert_object_equals_fixed(result, entries.cat.response,
+ assert_response_equals(result, entries.cat.response,
'Cache.match should ignore URL fragment.');
});
}, 'Cache.match with URL containing fragment');
@@ -90,7 +90,7 @@ prepopulated_cache_test(simple_entries, function(cache, entries) {
prepopulated_cache_test(simple_entries, function(cache, entries) {
return cache.match(entries.secret_cat.request.url)
.then(function(result) {
- assert_object_equals_fixed(
+ assert_response_equals(
result, entries.secret_cat.response,
'Cache.match should not ignore embedded credentials');
});
@@ -99,7 +99,7 @@ prepopulated_cache_test(simple_entries, function(cache, entries) {
prepopulated_cache_test(vary_entries, function(cache, entries) {
return cache.match('http://example.com/c')
.then(function(result) {
- assert_object_in_array(
+ assert_response_in_array(
result,
[
entries.vary_wildcard.response,
@@ -126,7 +126,7 @@ cache_test(function(cache) {
return cache.match(request.url);
})
.then(function(result) {
- assert_object_equals_fixed(
+ assert_response_equals(
result, response,
'Cache.match should return a Response object that has the same ' +
'properties as the stored response.');
@@ -182,7 +182,7 @@ prepopulated_cache_test(simple_entries, function(cache, entries) {
var response = entries.non_2xx_response.response;
return cache.match(entries.non_2xx_response.request.url)
.then(function(result) {
- assert_object_equals_fixed(
+ assert_response_equals(
result, entries.non_2xx_response.response,
'Cache.match should return a Response object that has the ' +
'same properties as a stored non-2xx response.');
@@ -193,7 +193,7 @@ prepopulated_cache_test(simple_entries, function(cache, entries) {
var response = entries.error_response.response;
return cache.match(entries.error_response.request.url)
.then(function(result) {
- assert_object_equals_fixed(
+ assert_response_equals(
result, entries.error_response.response,
'Cache.match should return a Response object that has the ' +
'same properties as a stored network error response.');

Powered by Google App Engine
This is Rietveld 408576698