Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: LayoutTests/http/tests/cachestorage/script-tests/cache-matchAll.js

Issue 1295633003: Cache Storage: replace assert_object_equals w/ assert_response_equals (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Review feedback and rebased Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/http/tests/cachestorage/script-tests/cache-matchAll.js
diff --git a/LayoutTests/http/tests/cachestorage/script-tests/cache-matchAll.js b/LayoutTests/http/tests/cachestorage/script-tests/cache-matchAll.js
index 46e7edd43b8d956e217a4cfe41f543725f903dc1..480109005f48b5f7600db59868437f5e0c83f32c 100644
--- a/LayoutTests/http/tests/cachestorage/script-tests/cache-matchAll.js
+++ b/LayoutTests/http/tests/cachestorage/script-tests/cache-matchAll.js
@@ -7,7 +7,7 @@ if (self.importScripts) {
prepopulated_cache_test(simple_entries, function(cache, entries) {
return cache.matchAll('not-present-in-the-cache')
.then(function(result) {
- assert_array_equivalent(
+ assert_response_array_equivalent(
result, [],
'Cache.matchAll should resolve with an empty array on failure.');
});
@@ -16,7 +16,7 @@ prepopulated_cache_test(simple_entries, function(cache, entries) {
prepopulated_cache_test(simple_entries, function(cache, entries) {
return cache.matchAll(entries.a.request.url)
.then(function(result) {
- assert_array_equivalent(result, [entries.a.response],
+ assert_response_array_equivalent(result, [entries.a.response],
'Cache.matchAll should match by URL.');
});
}, 'Cache.matchAll with URL');
@@ -24,7 +24,7 @@ prepopulated_cache_test(simple_entries, function(cache, entries) {
prepopulated_cache_test(simple_entries, function(cache, entries) {
return cache.matchAll(entries.a.request)
.then(function(result) {
- assert_array_equivalent(result, [entries.a.response],
+ assert_response_array_equivalent(result, [entries.a.response],
'Cache.matchAll should match by Request.');
});
}, 'Cache.matchAll with Request');
@@ -32,7 +32,7 @@ prepopulated_cache_test(simple_entries, function(cache, entries) {
prepopulated_cache_test(simple_entries, function(cache, entries) {
return cache.matchAll(new Request(entries.a.request.url))
.then(function(result) {
- assert_array_equivalent(result, [entries.a.response],
+ assert_response_array_equivalent(result, [entries.a.response],
'Cache.matchAll should match by Request.');
});
}, 'Cache.matchAll with new Request');
@@ -41,7 +41,7 @@ prepopulated_cache_test(simple_entries, function(cache, entries) {
return cache.matchAll(entries.a.request,
{ignoreSearch: true})
.then(function(result) {
- assert_array_equivalent(
+ assert_response_array_equivalent(
result,
[
entries.a.response,
@@ -58,7 +58,7 @@ prepopulated_cache_test(simple_entries, function(cache, entries) {
return cache.matchAll(entries.a_with_query.request,
{ignoreSearch: true})
.then(function(result) {
- assert_array_equivalent(
+ assert_response_array_equivalent(
result,
[
entries.a.response,
@@ -73,7 +73,7 @@ prepopulated_cache_test(simple_entries, function(cache, entries) {
prepopulated_cache_test(simple_entries, function(cache, entries) {
return cache.matchAll(entries.cat.request.url + '#mouse')
.then(function(result) {
- assert_array_equivalent(
+ assert_response_array_equivalent(
result,
[
entries.cat.response,
@@ -85,7 +85,7 @@ prepopulated_cache_test(simple_entries, function(cache, entries) {
prepopulated_cache_test(simple_entries, function(cache, entries) {
return cache.matchAll('http')
.then(function(result) {
- assert_array_equivalent(
+ assert_response_array_equivalent(
result, [],
'Cache.matchAll should treat query as a URL and not ' +
'just a string fragment.');
@@ -95,7 +95,7 @@ prepopulated_cache_test(simple_entries, function(cache, entries) {
prepopulated_cache_test(simple_entries, function(cache, entries) {
return cache.matchAll(entries.secret_cat.request.url)
.then(function(result) {
- assert_array_equivalent(
+ assert_response_array_equivalent(
result, [entries.secret_cat.response],
'Cache.matchAll should not ignore embedded credentials');
});
@@ -104,7 +104,7 @@ prepopulated_cache_test(simple_entries, function(cache, entries) {
prepopulated_cache_test(vary_entries, function(cache, entries) {
return cache.matchAll('http://example.com/c')
.then(function(result) {
- assert_array_equivalent(
+ assert_response_array_equivalent(
result,
[
entries.vary_wildcard.response,
@@ -121,7 +121,7 @@ prepopulated_cache_test(vary_entries, function(cache, entries) {
{headers: {'Cookies': 'none-of-the-above'}}));
})
.then(function(result) {
- assert_array_equivalent(
+ assert_response_array_equivalent(
result,
[
entries.vary_wildcard.response
@@ -137,7 +137,7 @@ prepopulated_cache_test(vary_entries, function(cache, entries) {
{headers: {'Cookies': 'is-for-cookie'}}));
})
.then(function(result) {
- assert_array_equivalent(
+ assert_response_array_equivalent(
result,
[entries.vary_cookie_is_cookie.response],
'Cache.matchAll should match the entire header if a vary header ' +
@@ -149,7 +149,7 @@ prepopulated_cache_test(vary_entries, function(cache, entries) {
return cache.matchAll('http://example.com/c',
{ignoreVary: true})
.then(function(result) {
- assert_array_equivalent(
+ assert_response_array_equivalent(
result,
[
entries.vary_cookie_is_cookie.response,

Powered by Google App Engine
This is Rietveld 408576698