net/url_request/url_request_job_factory_impl.h - Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_job_factory_impl.h

Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/webui/url_data_manager_backend_unittest.cc ('K') | « net/url_request/url_request_ftp_job_unittest.cc ('k') | net/url_request/url_request_job_factory_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/url_request/url_request_job_factory_impl.h

diff --git a/net/url_request/url_request_job_factory_impl.h b/net/url_request/url_request_job_factory_impl.h

index 8d1d8d96c99949ae32f49b53a23708bac8aa8d52..92ffeee93a7de295a42f3a53491ede5b33df6365 100644

--- a/net/url_request/url_request_job_factory_impl.h

+++ b/net/url_request/url_request_job_factory_impl.h

@@ -10,6 +10,7 @@

#include "base/basictypes.h"

#include "base/compiler_specific.h"

+#include "base/memory/scoped_ptr.h"

#include "net/base/net_export.h"

#include "net/url_request/url_request_job_factory.h"

@@ -26,7 +27,7 @@ class NET_EXPORT URLRequestJobFactoryImpl : public URLRequestJobFactory {

// failure (a ProtocolHandler already exists for |scheme|). On success,

// URLRequestJobFactory takes ownership of |protocol_handler|.

davidben 2015/08/18 20:40:37 Remove "On success, [...] takes ownership [...]" s

svaldez 2015/08/18 22:12:44 Done.

bool SetProtocolHandler(const std::string& scheme,

- ProtocolHandler* protocol_handler);

+ scoped_ptr<ProtocolHandler> protocol_handler);

// URLRequestJobFactory implementation

URLRequestJob* MaybeCreateJobWithProtocolHandler(