content/browser/webui/url_data_manager_backend_unittest.cc - Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/webui/url_data_manager_backend_unittest.cc

Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_url_request_job_unittest.cc ('K') | « content/browser/streams/stream_url_request_job_unittest.cc ('k') | content/public/browser/android/content_protocol_handler.h » ('j') | net/url_request/url_request_job_factory_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/webui/url_data_manager_backend_unittest.cc

diff --git a/content/browser/webui/url_data_manager_backend_unittest.cc b/content/browser/webui/url_data_manager_backend_unittest.cc

index 1030533da1245791412e654f1e69341c56cdd9a8..5be284de3f95bc8312ed4b07f44c9bbf7f0a1beb 100644

--- a/content/browser/webui/url_data_manager_backend_unittest.cc

+++ b/content/browser/webui/url_data_manager_backend_unittest.cc

@@ -43,9 +43,8 @@ class UrlDataManagerBackendTest : public testing::Test {

UrlDataManagerBackendTest() {

// URLRequestJobFactory takes ownership of the passed in ProtocolHandler.

url_request_job_factory_.SetProtocolHandler(

- "chrome",

- URLDataManagerBackend::CreateProtocolHandler(

- &resource_context_, false, nullptr, nullptr));

+ "chrome", make_scoped_ptr(URLDataManagerBackend::CreateProtocolHandler(

davidben 2015/08/18 20:40:37 URLDataManagerBackend::CreateProtocolHandler coudl

+ &resource_context_, false, nullptr, nullptr)));

url_request_context_.set_job_factory(&url_request_job_factory_);

}