net/url_request/url_request_ftp_job_unittest.cc - Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_ftp_job_unittest.cc

Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/webui/url_data_manager_backend_unittest.cc ('K') | « net/url_request/url_request_context_builder.cc ('k') | net/url_request/url_request_job_factory_impl.h » ('j') | net/url_request/url_request_job_factory_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/url_request/url_request_ftp_job_unittest.cc

diff --git a/net/url_request/url_request_ftp_job_unittest.cc b/net/url_request/url_request_ftp_job_unittest.cc

index 4a8178dd448eb60e8721e7b11e23e870f2b4f7d7..093b74a748e51f46227d975535ead449f5149784 100644

--- a/net/url_request/url_request_ftp_job_unittest.cc

+++ b/net/url_request/url_request_ftp_job_unittest.cc

@@ -57,7 +57,8 @@ class FtpTestURLRequestContext : public TestURLRequestContext {

context_storage_.set_proxy_service(proxy_service);

set_network_delegate(network_delegate);

URLRequestJobFactoryImpl* job_factory = new URLRequestJobFactoryImpl;

- job_factory->SetProtocolHandler("ftp", ftp_protocol_handler_);

+ job_factory->SetProtocolHandler("ftp",

+ make_scoped_ptr(ftp_protocol_handler_));

context_storage_.set_job_factory(job_factory);

Init();

}