ios/web/shell/shell_url_request_context_getter.cc - Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/shell/shell_url_request_context_getter.cc

Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/webui/url_data_manager_backend_unittest.cc ('K') | « ios/web/net/request_tracker_impl_unittest.mm ('k') | mojo/services/network/url_loader_impl_apptest.cc » ('j') | net/url_request/url_request_job_factory_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/web/shell/shell_url_request_context_getter.cc

diff --git a/ios/web/shell/shell_url_request_context_getter.cc b/ios/web/shell/shell_url_request_context_getter.cc

index 8cffb68fae6fa84c9860aa7764ee0a0b8d4e6c5c..5d8c660357c7d642b569e7dd97d21db546507846 100644

--- a/ios/web/shell/shell_url_request_context_getter.cc

+++ b/ios/web/shell/shell_url_request_context_getter.cc

@@ -141,8 +141,8 @@ net::URLRequestContext* ShellURLRequestContextGetter::GetURLRequestContext() {

scoped_ptr<net::URLRequestJobFactoryImpl> job_factory(

new net::URLRequestJobFactoryImpl());

- bool set_protocol =

- job_factory->SetProtocolHandler("data", new net::DataProtocolHandler);

+ bool set_protocol = job_factory->SetProtocolHandler(

+ "data", make_scoped_ptr(new net::DataProtocolHandler));

DCHECK(set_protocol);

storage_->set_job_factory(job_factory.release());