Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Unified Diff: content/browser/service_worker/service_worker_url_request_job_unittest.cc

Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_url_request_job_unittest.cc
diff --git a/content/browser/service_worker/service_worker_url_request_job_unittest.cc b/content/browser/service_worker/service_worker_url_request_job_unittest.cc
index 149c524e7435ff456ec21f97d7853a80878eb02f..3a4e7a70732bfaf7b3ca445184a49c9969fb9938 100644
--- a/content/browser/service_worker/service_worker_url_request_job_unittest.cc
+++ b/content/browser/service_worker/service_worker_url_request_job_unittest.cc
@@ -183,11 +183,12 @@ class ServiceWorkerURLRequestJobTest : public testing::Test {
url_request_job_factory_.reset(new net::URLRequestJobFactoryImpl);
url_request_job_factory_->SetProtocolHandler(
"http",
- new MockHttpProtocolHandler(provider_host->AsWeakPtr(),
- browser_context_->GetResourceContext(),
- blob_storage_context->AsWeakPtr()));
+ make_scoped_ptr(new MockHttpProtocolHandler(
+ provider_host->AsWeakPtr(), browser_context_->GetResourceContext(),
+ blob_storage_context->AsWeakPtr())));
url_request_job_factory_->SetProtocolHandler(
- "blob", CreateMockBlobProtocolHandler(blob_storage_context));
+ "blob",
+ make_scoped_ptr(CreateMockBlobProtocolHandler(blob_storage_context)));
davidben 2015/08/18 20:40:37 CreateMockBlobProtocolHandler could just return a
svaldez 2015/08/18 22:12:44 Done.
url_request_context_.set_job_factory(url_request_job_factory_.get());
helper_->context()->AddProviderHost(provider_host.Pass());

Powered by Google App Engine
This is Rietveld 408576698