content/browser/loader/resource_loader_unittest.cc - Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/resource_loader_unittest.cc

Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/loader/navigation_url_loader_unittest.cc ('K') | « content/browser/loader/navigation_url_loader_unittest.cc ('k') | content/browser/service_worker/service_worker_url_request_job_unittest.cc » ('j') | content/browser/service_worker/service_worker_url_request_job_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/resource_loader_unittest.cc

diff --git a/content/browser/loader/resource_loader_unittest.cc b/content/browser/loader/resource_loader_unittest.cc

index 0131f2f7448ee5712b99d60bfc2806ef11ad661e..0b1fa4825b833921d4f20493f8e099fbf87eee94 100644

--- a/content/browser/loader/resource_loader_unittest.cc

+++ b/content/browser/loader/resource_loader_unittest.cc

@@ -558,7 +558,8 @@ class ResourceLoaderTest : public testing::Test,

}

void SetUp() override {

- job_factory_.SetProtocolHandler("test", CreateProtocolHandler());

+ job_factory_.SetProtocolHandler("test",

+ make_scoped_ptr(CreateProtocolHandler()));

davidben 2015/08/18 20:40:37 CreateProtocolHandler could just return a scoped_p

svaldez 2015/08/18 22:12:44 Done.

browser_context_.reset(new TestBrowserContext());

scoped_refptr<SiteInstance> site_instance =