Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Unified Diff: content/browser/loader/navigation_url_loader_unittest.cc

Issue 1295523006: Using scoped_ptr for URLRequestJobFactoryImpl::SetProtocolHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/navigation_url_loader_unittest.cc
diff --git a/content/browser/loader/navigation_url_loader_unittest.cc b/content/browser/loader/navigation_url_loader_unittest.cc
index df5e9d6aeacc7b935c4d3c6eba5771e2c6257fd7..2cc147a6b4e0386b69d974d015b914b5f13e495f 100644
--- a/content/browser/loader/navigation_url_loader_unittest.cc
+++ b/content/browser/loader/navigation_url_loader_unittest.cc
@@ -163,10 +163,12 @@ class NavigationURLLoaderTest : public testing::Test {
browser_context_->GetResourceContext()->GetRequestContext();
// Attach URLRequestTestJob and make streams work.
job_factory_.SetProtocolHandler(
- "test", net::URLRequestTestJob::CreateProtocolHandler());
+ "test",
+ make_scoped_ptr(net::URLRequestTestJob::CreateProtocolHandler()));
davidben 2015/08/18 20:40:37 CreateProtocolHandler could just return a scoped_p
svaldez 2015/08/18 22:12:44 Done.
job_factory_.SetProtocolHandler(
- "blob", new StreamProtocolHandler(
- StreamContext::GetFor(browser_context_.get())->registry()));
+ "blob",
+ make_scoped_ptr(new StreamProtocolHandler(
+ StreamContext::GetFor(browser_context_.get())->registry())));
request_context->set_job_factory(&job_factory_);
// NavigationURLLoader is only used for browser-side navigations.

Powered by Google App Engine
This is Rietveld 408576698