Fix almost all leaks of InterruptableThreadState instances.

Fix almost all leaks of InterruptableThreadState instances.

The ITS field was being NULLed on every isolate exit, causing leaks.

Move the ITS field out of Thread::State since it should not be saved/restored by ThreadRegistry (it contains the OS ThreadId and is updated via Profiler).

Delete the ITS in ~Thread, which is called for all threads except embedder-created threads on Windows, so for each of those there is still a small leak.


BUG=https://github.com/dart-lang/sdk/issues/24129

[koda, 2015-08-20 05:02:48]

koda@google.com changed reviewers:
+ iposva@google.com, johnmccutchan@google.com

[koda, 2015-08-20 14:34:30]

On 2015/08/20 05:02:49, koda wrote:

Note that this seems to be superseded by John's CL (which also goes further and
merges the ITS into Thread):
https://codereview.chromium.org/1293253005/

[koda, 2015-08-20 22:29:27]

That change is now committed, but I'll keep this CL around for now in case we
want it as a minimally disruptive cherry pick for 1.12. Let me know what you
think.