Fix almost all leaks of InterruptableThreadState instances.

runtime/vm/thread.h

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_THREAD_H_
 #define VM_THREAD_H_
 
 #include "vm/globals.h"
 #include "vm/os_thread.h"
 #include "vm/store_buffer.h"
@@ skipping 106 matching lines @@
   StackResource* top_resource() const { return state_.top_resource; }
   void set_top_resource(StackResource* value) {
     state_.top_resource = value;
   }
   static intptr_t top_resource_offset() {
     return OFFSET_OF(Thread, state_) + OFFSET_OF(State, top_resource);
   }
 
   void set_thread_state(InterruptableThreadState* state) {
     ASSERT((thread_state() == NULL) || (state == NULL));
-    state_.thread_state = state;
+    thread_state_ = state;
   }
 
   InterruptableThreadState* thread_state() const {
-    return state_.thread_state;
+    return thread_state_;
   }
 
   static intptr_t heap_offset() {
     return OFFSET_OF(Thread, heap_);
   }
 
   int32_t no_handle_scope_depth() const {
 #if defined(DEBUG)
     return state_.no_handle_scope_depth;
 #else
@@ skipping 51 matching lines @@
 #endif
   }
 
   // Collection of isolate-specific state of a thread that is saved/restored
   // on isolate exit/re-entry.
   struct State {
     Zone* zone;
     uword top_exit_frame_info;
     StackResource* top_resource;
     TimelineEventBlock* timeline_block;
-    // TODO(koda): Migrate individual fields of InterruptableThreadState.
-    InterruptableThreadState* thread_state;
     LongJumpScope* long_jump_base;
 #if defined(DEBUG)
     HandleScope* top_handle_scope;
     intptr_t no_handle_scope_depth;
     int32_t no_safepoint_scope_depth;
 #endif
   };
 
 #define DEFINE_OFFSET_METHOD(type_name, member_name, expr, default_init_value) \
   static intptr_t member_name##offset() {                                      \
@@ skipping 18 matching lines @@
     state_.long_jump_base = value;
   }
 
  private:
   static ThreadLocalKey thread_key_;
 
   Isolate* isolate_;
   Heap* heap_;
   State state_;
   StoreBufferBlock* store_buffer_block_;
+  // TODO(koda): Migrate individual fields of InterruptableThreadState.
+  InterruptableThreadState* thread_state_;
 #define DECLARE_MEMBERS(type_name, member_name, expr, default_init_value)      \
   type_name member_name;
 CACHED_CONSTANTS_LIST(DECLARE_MEMBERS)
 #undef DECLARE_MEMBERS
 
   explicit Thread(bool init_vm_constants = true);
 
   void InitVMConstants();
 
   void ClearState() {
@@ skipping 19 matching lines @@
   friend class ApiZone;
   friend class Isolate;
   friend class StackZone;
   friend class ThreadRegistry;
   DISALLOW_COPY_AND_ASSIGN(Thread);
 };
 
 }  // namespace dart
 
 #endif  // VM_THREAD_H_