chrome/browser/speech/tts_android.cc - Issue 1294333002: Fix wrong usages of ScopedJavaLocalRef::Release().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/speech/tts_android.cc

Issue 1294333002: Fix wrong usages of ScopedJavaLocalRef::Release(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comment to Release() explaining it should not be used to call java methods Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/speech/tts_android.cc

diff --git a/chrome/browser/speech/tts_android.cc b/chrome/browser/speech/tts_android.cc

index be3592cc56e87e4788a67b0bee9d566900266163..7fe5b02c0a13213e040a8143c08fbbf3654ccbd0 100644

--- a/chrome/browser/speech/tts_android.cc

+++ b/chrome/browser/speech/tts_android.cc

@@ -45,11 +45,10 @@ bool TtsPlatformImplAndroid::Speak(

const UtteranceContinuousParameters& params) {

JNIEnv* env = AttachCurrentThread();

jboolean success = Java_TtsPlatformImpl_speak(

- env, java_ref_.obj(),

- utterance_id,

- base::android::ConvertUTF8ToJavaString(env, utterance).Release(),

- base::android::ConvertUTF8ToJavaString(env, lang).Release(),

- params.rate, params.pitch, params.volume);

+ env, java_ref_.obj(), utterance_id,

+ base::android::ConvertUTF8ToJavaString(env, utterance).obj(),

+ base::android::ConvertUTF8ToJavaString(env, lang).obj(), params.rate,

+ params.pitch, params.volume);

if (!success)

return false;