components/cronet/android/test/test_upload_data_stream_handler.cc - Issue 1294333002: Fix wrong usages of ScopedJavaLocalRef::Release().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/test_upload_data_stream_handler.cc

Issue 1294333002: Fix wrong usages of ScopedJavaLocalRef::Release(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comment to Release() explaining it should not be used to call java methods Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/cronet/android/test/test_upload_data_stream_handler.cc

diff --git a/components/cronet/android/test/test_upload_data_stream_handler.cc b/components/cronet/android/test/test_upload_data_stream_handler.cc

index ae324d06458ceea1c3b3ca6a2a91301a5fb5469c..1c3e68327ab72129fcb8595ca95fc16ca51144c0 100644

--- a/components/cronet/android/test/test_upload_data_stream_handler.cc

+++ b/components/cronet/android/test/test_upload_data_stream_handler.cc

@@ -164,7 +164,7 @@ void TestUploadDataStreamHandler::NotifyJavaReadCompleted() {

data_read = std::string(read_buffer_->data(), bytes_read_);

cronet::Java_TestUploadDataStreamHandler_onReadCompleted(

env, jtest_upload_data_stream_handler_.obj(), bytes_read_,

- base::android::ConvertUTF8ToJavaString(env, data_read).Release());

+ base::android::ConvertUTF8ToJavaString(env, data_read).obj());

}

static jlong CreateTestUploadDataStreamHandler(

« no previous file with comments | « chrome/browser/speech/tts_android.cc ('k') | components/gcm_driver/gcm_driver_android.cc » ('j') | no next file with comments »