chrome/browser/android/recently_closed_tabs_bridge.cc - Issue 1294333002: Fix wrong usages of ScopedJavaLocalRef::Release().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/recently_closed_tabs_bridge.cc

Issue 1294333002: Fix wrong usages of ScopedJavaLocalRef::Release(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comment to Release() explaining it should not be used to call java methods Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/recently_closed_tabs_bridge.cc

diff --git a/chrome/browser/android/recently_closed_tabs_bridge.cc b/chrome/browser/android/recently_closed_tabs_bridge.cc

index aaa2d7c71350450dc472170f91d81fb8973f9249..0049595d9a3a612c8a2cd27c72dd582979efbde1 100644

--- a/chrome/browser/android/recently_closed_tabs_bridge.cc

+++ b/chrome/browser/android/recently_closed_tabs_bridge.cc

@@ -30,9 +30,9 @@ void AddTabToList(JNIEnv* env,

tab->navigations.at(tab->current_navigation_index);

Java_RecentlyClosedBridge_pushTab(

env, jtabs_list, entry->id,

- ConvertUTF16ToJavaString(env, current_navigation.title()).Release(),

+ ConvertUTF16ToJavaString(env, current_navigation.title()).obj(),

ConvertUTF8ToJavaString(env, current_navigation.virtual_url().spec())

- .Release());

+ .obj());

}

void AddTabsToList(JNIEnv* env,