Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Issue 1301723002: MD Downloads: update "expanded" (i.e. in progress) cards (Closed)

Created:
5 years, 4 months ago by Dan Beam
Modified:
5 years, 4 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: update "expanded" (i.e. in progress) cards 1) Top-align file icons for progressing downloads 2) Remove progress rounded corners (not in new mocks, there were issues) BUG=520728 R=groby@chromium.org Committed: https://crrev.com/c547d4f8e8536241d535b699cff3a8c22be6016a Cr-Commit-Position: refs/heads/master@{#344033}

Patch Set 1 #

Patch Set 2 : add dep #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M chrome/browser/resources/md_downloads/item.css View 1 2 chunks +8 lines, -3 lines 1 comment Download
M chrome/browser/resources/md_downloads/item.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_downloads/item.js View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (1 generated)
Dan Beam
5 years, 4 months ago (2015-08-18 00:37:29 UTC) #1
groby-ooo-7-16
LGTM
5 years, 4 months ago (2015-08-18 18:25:02 UTC) #2
michaelpg
https://codereview.chromium.org/1301723002/diff/20001/chrome/browser/resources/md_downloads/item.css File chrome/browser/resources/md_downloads/item.css (right): https://codereview.chromium.org/1301723002/diff/20001/chrome/browser/resources/md_downloads/item.css#newcode42 chrome/browser/resources/md_downloads/item.css:42: border-radius: 2px; /* TODO(dbeam): why does this differ from ...
5 years, 4 months ago (2015-08-18 19:57:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301723002/20001
5 years, 4 months ago (2015-08-18 20:41:44 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-18 21:18:33 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 21:19:05 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c547d4f8e8536241d535b699cff3a8c22be6016a
Cr-Commit-Position: refs/heads/master@{#344033}

Powered by Google App Engine
This is Rietveld 408576698