Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.h

Issue 1293963002: Fixing the Position of Context Menu for BrowserPlugin (<webview>) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/browser_plugin_guest.h
diff --git a/content/browser/browser_plugin/browser_plugin_guest.h b/content/browser/browser_plugin/browser_plugin_guest.h
index 868fcc8a35ab07c5920b2e70f48a9c25ceca03b3..ec75b63fa8ccbb26e4f5f41312faab36637951a3 100644
--- a/content/browser/browser_plugin/browser_plugin_guest.h
+++ b/content/browser/browser_plugin/browser_plugin_guest.h
@@ -187,6 +187,8 @@ class CONTENT_EXPORT BrowserPluginGuest : public GuestHost,
gfx::Point GetScreenCoordinates(const gfx::Point& relative_position) const;
+ void SetContextMenuPosition(const gfx::Point& position);
+
// Helper to send messages to embedder. If this guest is not yet attached,
// then IPCs will be queued until attachment.
void SendMessageToEmbedder(IPC::Message* msg);
@@ -440,6 +442,9 @@ class CONTENT_EXPORT BrowserPluginGuest : public GuestHost,
// Indicates the URL dragged into the guest if any.
GURL dragged_url_;
+ // An offset used to find the position of the context menu
+ gfx::Point context_menu_position_;
wjmaclean 2015/08/17 13:05:23 Why do we have this? It doesn't seem to be used (o
Ehsaan 2015/08/17 14:09:12 My mistake! I was initially setting this value her
+
// Guests generate frames and send a CompositorFrameSwapped (CFS) message
// indicating the next frame is ready to be positioned and composited.
// Subsequent frames are not generated until the IPC is ACKed. We would like

Powered by Google App Engine
This is Rietveld 408576698