Fixing the Position of Context Menu for BrowserPlugin (<webview>)

content/browser/browser_plugin/browser_plugin_guest.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // A BrowserPluginGuest is the browser side of a browser <--> embedder
 // renderer channel. A BrowserPlugin (a WebPlugin) is on the embedder
 // renderer side of browser <--> embedder renderer communication.
 //
 // BrowserPluginGuest lives on the UI thread of the browser process. Any
 // messages about the guest render process that the embedder might be interested
@@ skipping 169 matching lines @@
   int LoadURLWithParams(
       const NavigationController::LoadURLParams& load_params) override;
   void SizeContents(const gfx::Size& new_size) override;
   void WillDestroy() override;
 
   // Exposes the protected web_contents() from WebContentsObserver.
   WebContentsImpl* GetWebContents() const;
 
   gfx::Point GetScreenCoordinates(const gfx::Point& relative_position) const;
 
+  void SetContextMenuPosition(const gfx::Point& position);
+
   // Helper to send messages to embedder. If this guest is not yet attached,
   // then IPCs will be queued until attachment.
   void SendMessageToEmbedder(IPC::Message* msg);
 
   // Returns whether the guest is attached to an embedder.
   bool attached() const { return attached_; }
 
   // Returns true when an attachment has taken place since the last time the
   // compositor surface was set.
   bool has_attached_since_surface_set() const {
@@ skipping 233 matching lines @@
   // Last seen state of drag status update.
   blink::WebDragStatus last_drag_status_;
   // Whether or not our embedder has seen a SystemDragEnded() call.
   bool seen_embedder_system_drag_ended_;
   // Whether or not our embedder has seen a DragSourceEndedAt() call.
   bool seen_embedder_drag_source_ended_at_;
 
   // Indicates the URL dragged into the guest if any.
   GURL dragged_url_;
 
+  // An offset used to find the position of the context menu
+  gfx::Point context_menu_position_;

[wjmaclean, 2015/08/17 13:05:23]

Why do we have this? It doesn't seem to be used (or did I miss something?)

[Ehsaan, 2015/08/17 14:09:12]

My mistake! I was initially setting this value here, but then moved it to the
ChromeWebViewGuestDelegate. I will remove this.

+
   // Guests generate frames and send a CompositorFrameSwapped (CFS) message
   // indicating the next frame is ready to be positioned and composited.
   // Subsequent frames are not generated until the IPC is ACKed. We would like
   // to ensure that the guest generates frames on attachment so we directly ACK
   // an unACKed CFS. ACKs could get lost between the time a guest is detached
   // from a container and the time it is attached elsewhere. This mitigates this
   // race by ensuring the guest is ACKed on attachment.
   scoped_ptr<FrameMsg_CompositorFrameSwapped_Params> last_pending_frame_;
 
   // This is a queue of messages that are destined to be sent to the embedder
   // once the guest is attached to a particular embedder.
   std::deque<linked_ptr<IPC::Message> > pending_messages_;
 
   BrowserPluginGuestDelegate* const delegate_;
 
   // Weak pointer used to ask GeolocationPermissionContext about geolocation
   // permission.
   base::WeakPtrFactory<BrowserPluginGuest> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowserPluginGuest);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_BROWSER_PLUGIN_BROWSER_PLUGIN_GUEST_H_