components/guest_view/browser/guest_view_base.cc - Issue 1293963002: Fixing the Position of Context Menu for BrowserPlugin (<webview>)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/guest_view/browser/guest_view_base.cc

Issue 1293963002: Fixing the Position of Context Menu for BrowserPlugin (<webview>) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/guest_view/browser/guest_view_base.h ('k') | content/browser/browser_plugin/browser_plugin_guest.h » ('j') | content/browser/browser_plugin/browser_plugin_guest.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/guest_view/browser/guest_view_base.cc

diff --git a/components/guest_view/browser/guest_view_base.cc b/components/guest_view/browser/guest_view_base.cc

index 5b4fa13b9365623b7129a8547586eb5ddeaf4225..e3fae6eab08e79e4d175993633a0da1ee84be4bf 100644

--- a/components/guest_view/browser/guest_view_base.cc

+++ b/components/guest_view/browser/guest_view_base.cc

@@ -370,6 +370,8 @@ bool GuestViewBase::ZoomPropagatesFromEmbedderToGuest() const {

return true;

}

+void GuestViewBase::SetContextMenuPosition(const gfx::Point& position) {}

content::WebContents* GuestViewBase::CreateNewGuestWindow(

const content::WebContents::CreateParams& create_params) {

auto guest_manager = GuestViewManager::FromBrowserContext(browser_context());