Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 129373002: Disable optimizations GM for 565 targets. (Closed)

Created:
6 years, 11 months ago by mtklein
Modified:
6 years, 11 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Disable optimizations GM for 565 targets. BUG=skia:1994 Committed: http://code.google.com/p/skia/source/detail?r=12991

Patch Set 1 #

Patch Set 2 : refer to bug #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M gm/optimizations.cpp View 1 1 chunk +8 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
6 years, 11 months ago (2014-01-08 21:15:30 UTC) #1
robertphillips
lgtm + 1 nit https://codereview.chromium.org/129373002/diff/40001/gm/optimizations.cpp File gm/optimizations.cpp (right): https://codereview.chromium.org/129373002/diff/40001/gm/optimizations.cpp#newcode313 gm/optimizations.cpp:313: protected: add virtual prefix?
6 years, 11 months ago (2014-01-09 12:53:30 UTC) #2
mtklein
https://codereview.chromium.org/129373002/diff/40001/gm/optimizations.cpp File gm/optimizations.cpp (right): https://codereview.chromium.org/129373002/diff/40001/gm/optimizations.cpp#newcode313 gm/optimizations.cpp:313: protected: On 2014/01/09 12:53:30, robertphillips wrote: > add virtual ...
6 years, 11 months ago (2014-01-09 13:08:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/129373002/40001
6 years, 11 months ago (2014-01-09 15:08:38 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 16:45:42 UTC) #5
Message was sent while issue was closed.
Change committed as 12991

Powered by Google App Engine
This is Rietveld 408576698