Disable optimizations GM for 565 targets.

gm/optimizations.cpp

Index: gm/optimizations.cpp
diff --git a/gm/optimizations.cpp b/gm/optimizations.cpp
index 6b7d2843fc688d78fd03855eade2c4276e0ba28f..8d0b7caa84b500423cc8354cfc13494136787b31 100644
--- a/gm/optimizations.cpp
+++ b/gm/optimizations.cpp
@@ -311,6 +311,14 @@ public:
     static const int kHeight = 800;
 
 protected:

[robertphillips, 2014/01/09 12:53:30]

add virtual prefix?

[mtklein, 2014/01/09 13:08:48]

Happy to add it, but now that I'm thinking about it, adding virtual seems like
it might give the wrong affordance.  We're not expecting subclasses of
OptimizationsGM.  virtual screams "Override me!" (like SK_OVERRIDE screams "I
override you!").  Though I don't claim to have written code consistent with this
myself; just spitballing now.

+    uint32_t onGetFlags() const SK_OVERRIDE {
+        // One optimization changes the color drawn slightly in a 565 target.
+        // We've decided it's innocuous, so we disable this GM when targeting 565.
+        // Revisit this if we get finer-grained control: it'd be nice to keep drawing directly.
+        // For more, see skia:1994.
+        return skiagm::GM::kSkip565_Flag;
+    }
+
     SkString onShortName() {
         return SkString("optimizations");
     }