Disable optimizations GM for 565 targets.

gm/optimizations.cpp

 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "gm.h"
 #include "SkDebugCanvas.h"
 #include "SkPictureFlat.h"
@@ skipping 292 matching lines @@
 // test
 class OptimizationsGM : public skiagm::GM {
 public:
     OptimizationsGM() {
         this->makeCheckerboard();
     }
 
     static const int kWidth = 800;
     static const int kHeight = 800;
 
 protected:

[robertphillips, 2014/01/09 12:53:30]

add virtual prefix?

[mtklein, 2014/01/09 13:08:48]

Happy to add it, but now that I'm thinking about it, adding virtual seems like
it might give the wrong affordance.  We're not expecting subclasses of
OptimizationsGM.  virtual screams "Override me!" (like SK_OVERRIDE screams "I
override you!").  Though I don't claim to have written code consistent with this
myself; just spitballing now.

+    uint32_t onGetFlags() const SK_OVERRIDE {
+        // One optimization changes the color drawn slightly in a 565 target.
+        // We've decided it's innocuous, so we disable this GM when targeting 565.
+        // Revisit this if we get finer-grained control: it'd be nice to keep drawing directly.
+        // For more, see skia:1994.
+        return skiagm::GM::kSkip565_Flag;
+    }
+
     SkString onShortName() {
         return SkString("optimizations");
     }
 
     SkISize onISize() { return SkISize::Make(kWidth, kHeight); }
 
     typedef SkPicture* (*PFCreateOpt)(SkTDArray<DrawType> *preOptPattern,
                                       SkTDArray<DrawType> *postOptPattern,
                                       const SkBitmap& checkerBoard);
 
@@ skipping 82 matching lines @@
     }
 
     SkBitmap fCheckerboard;
 
     typedef skiagm::GM INHERITED;
 };
 
 //////////////////////////////////////////////////////////////////////////////
 
 DEF_GM( return new OptimizationsGM; )