Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1293583002: Introduce GrBatch subclasses GrDrawBatch and GrVertexBatch to prepare for non-drawing batches (Closed)

Created:
5 years, 4 months ago by bsalomon
Modified:
5 years, 4 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Introduce GrBatch subclasses GrDrawBatch and GrVertexBatch to prepare for non-drawing batches Committed: https://skia.googlesource.com/skia/+/abd30f54b7ff1704a8930c4307ea242d09425d02

Patch Set 1 #

Patch Set 2 : whitespace fix #

Patch Set 3 : remove duplicated fields in GrVertexBatch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+488 lines, -448 lines) Patch
M gm/beziereffects.cpp View 5 chunks +8 lines, -7 lines 0 comments Download
M gm/convexpolyeffect.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M include/gpu/GrDrawContext.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 5 chunks +7 lines, -8 lines 0 comments Download
M src/gpu/GrAADistanceFieldPathRenderer.cpp View 5 chunks +10 lines, -11 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 6 chunks +14 lines, -14 lines 0 comments Download
M src/gpu/GrAALinearizingConvexPathRenderer.cpp View 5 chunks +7 lines, -8 lines 0 comments Download
M src/gpu/GrAtlasTextContext.h View 3 chunks +6 lines, -5 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 5 chunks +9 lines, -10 lines 0 comments Download
M src/gpu/GrBatchTest.h View 2 chunks +12 lines, -12 lines 0 comments Download
M src/gpu/GrBatchTest.cpp View 1 chunk +35 lines, -35 lines 0 comments Download
M src/gpu/GrBufferedDrawTarget.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrBufferedDrawTarget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrCommandBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 5 chunks +11 lines, -10 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 7 chunks +13 lines, -14 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 4 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 4 chunks +6 lines, -5 lines 0 comments Download
M src/gpu/GrImmediateDrawTarget.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrImmediateDrawTarget.cpp View 1 chunk +7 lines, -4 lines 0 comments Download
M src/gpu/GrInOrderCommandBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrInOrderCommandBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 26 chunks +59 lines, -60 lines 0 comments Download
M src/gpu/GrPipelineBuilder.h View 3 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/GrPipelineBuilder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrProcOptInfo.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrProcOptInfo.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrReorderCommandBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrReorderCommandBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTargetCommands.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/GrTargetCommands.cpp View 2 chunks +10 lines, -3 lines 0 comments Download
M src/gpu/GrTessellatingPathRenderer.cpp View 3 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/batches/GrAAFillRectBatch.h View 1 chunk +10 lines, -10 lines 0 comments Download
M src/gpu/batches/GrAAFillRectBatch.cpp View 6 chunks +15 lines, -15 lines 0 comments Download
M src/gpu/batches/GrAAStrokeRectBatch.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrAAStrokeRectBatch.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/batches/GrBWFillRectBatch.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrBWFillRectBatch.cpp View 5 chunks +11 lines, -12 lines 0 comments Download
M src/gpu/batches/GrBatch.h View 1 2 6 chunks +84 lines, -60 lines 0 comments Download
M src/gpu/batches/GrBatch.cpp View 4 chunks +25 lines, -16 lines 0 comments Download
M src/gpu/batches/GrDrawAtlasBatch.h View 1 chunk +4 lines, -3 lines 0 comments Download
M src/gpu/batches/GrDrawAtlasBatch.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/batches/GrDrawVerticesBatch.h View 2 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/batches/GrDrawVerticesBatch.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/batches/GrRectBatchFactory.h View 2 chunks +18 lines, -18 lines 0 comments Download
M src/gpu/batches/GrRectBatchFactory.cpp View 4 chunks +19 lines, -20 lines 0 comments Download
M src/gpu/batches/GrStrokeRectBatch.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrStrokeRectBatch.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrTestBatch.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 6 chunks +10 lines, -11 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GrPorterDuffTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
bsalomon
The changes to GrBatch factories and subclasses are rote. The place to look is GrBatch.h, ...
5 years, 4 months ago (2015-08-13 19:50:24 UTC) #2
bsalomon
oops, sent this to the wrong Joshua.
5 years, 4 months ago (2015-08-13 19:51:07 UTC) #4
joshualitt
On 2015/08/13 19:51:07, bsalomon wrote: > oops, sent this to the wrong Joshua. lgtm
5 years, 4 months ago (2015-08-13 19:59:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293583002/20001
5 years, 4 months ago (2015-08-13 20:05:37 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/2664)
5 years, 4 months ago (2015-08-13 20:07:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293583002/20001
5 years, 4 months ago (2015-08-13 20:10:23 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.8-Clang-x86_64-Release-Trybot/builds/5029)
5 years, 4 months ago (2015-08-13 20:20:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293583002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293583002/40001
5 years, 4 months ago (2015-08-13 20:27:09 UTC) #16
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 20:34:52 UTC) #17
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/abd30f54b7ff1704a8930c4307ea242d09425d02

Powered by Google App Engine
This is Rietveld 408576698