Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 1293533005: HTMLPluginElement should use setNeedsCompositingUpdate() (Closed)

Created:
5 years, 4 months ago by esprehn
Modified:
5 years, 4 months ago
Reviewers:
pdr., ojan
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-rendering, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, sof, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

HTMLPluginElement should use setNeedsCompositingUpdate() HTMLPluginElement::loadPlugin was using scheduleSVGFilterLayerUpdateHack() to update the compositing state of the LayoutEmbeddedObject. Instead we can use the setNeedsCompositingUpdate() API which will cause only a compositing update and skip the wasteful style recalc on the <embed> or <object>. I also moved the call to updateSelfPaintingLayer into setNeedsCompositingUpdate since all callers of it actually want to do that too. After this the only user of scheduleSVGFilterLayerUpdateHack is actually SVG filters. R=ojan@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200861

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -18 lines) Patch
M Source/core/dom/Element.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/frame/RemoteFrame.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLPlugInElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/layout/compositing/DeprecatedPaintLayerCompositor.cpp View 1 chunk +2 lines, -9 lines 0 comments Download
M Source/web/WebPluginContainerImpl.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293533005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293533005/1
5 years, 4 months ago (2015-08-19 20:54:14 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-19 22:20:52 UTC) #4
esprehn
5 years, 4 months ago (2015-08-19 22:34:46 UTC) #6
pdr.
lgtm
5 years, 4 months ago (2015-08-19 23:13:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293533005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293533005/1
5 years, 4 months ago (2015-08-20 00:00:59 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 00:10:39 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200861

Powered by Google App Engine
This is Rietveld 408576698