Source/core/html/HTMLPlugInElement.cpp - Issue 1293533005: HTMLPluginElement should use setNeedsCompositingUpdate()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLPlugInElement.cpp

Issue 1293533005: HTMLPluginElement should use setNeedsCompositingUpdate() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLPlugInElement.cpp

diff --git a/Source/core/html/HTMLPlugInElement.cpp b/Source/core/html/HTMLPlugInElement.cpp

index ef7e5870086c20494b7cc1c48cddeaf0b9deda0b..cde57a859cdcdc7988fd99d701bf3571e05cf17c 100644

--- a/Source/core/html/HTMLPlugInElement.cpp

+++ b/Source/core/html/HTMLPlugInElement.cpp

@@ -556,7 +556,8 @@ bool HTMLPlugInElement::loadPlugin(const KURL& url, const String& mimeType, cons

}

setPlaceholder(nullptr);

document().setContainsPlugins();

- scheduleSVGFilterLayerUpdateHack();

+ // TODO(esprehn): WebPluginContainerImpl::setWebLayer also schedules a compositing update, do we need both?

+ setNeedsCompositingUpdate();

// Make sure any input event handlers introduced by the plugin are taken into account.

if (Page* page = document().frame()->page()) {

if (ScrollingCoordinator* scrollingCoordinator = page->scrollingCoordinator())