Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Side by Side Diff: Source/core/html/HTMLPlugInElement.cpp

Issue 1293533005: HTMLPluginElement should use setNeedsCompositingUpdate() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /** 1 /**
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de) 4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de)
5 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc. 5 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 538 matching lines...) Expand 10 before | Expand all | Expand 10 after
549 } 549 }
550 550
551 if (layoutObject) { 551 if (layoutObject) {
552 setWidget(widget); 552 setWidget(widget);
553 setPersistedPluginWidget(nullptr); 553 setPersistedPluginWidget(nullptr);
554 } else { 554 } else {
555 setPersistedPluginWidget(widget.get()); 555 setPersistedPluginWidget(widget.get());
556 } 556 }
557 setPlaceholder(nullptr); 557 setPlaceholder(nullptr);
558 document().setContainsPlugins(); 558 document().setContainsPlugins();
559 scheduleSVGFilterLayerUpdateHack(); 559 // TODO(esprehn): WebPluginContainerImpl::setWebLayer also schedules a compo siting update, do we need both?
560 setNeedsCompositingUpdate();
560 // Make sure any input event handlers introduced by the plugin are taken int o account. 561 // Make sure any input event handlers introduced by the plugin are taken int o account.
561 if (Page* page = document().frame()->page()) { 562 if (Page* page = document().frame()->page()) {
562 if (ScrollingCoordinator* scrollingCoordinator = page->scrollingCoordina tor()) 563 if (ScrollingCoordinator* scrollingCoordinator = page->scrollingCoordina tor())
563 scrollingCoordinator->notifyLayoutUpdated(); 564 scrollingCoordinator->notifyLayoutUpdated();
564 } 565 }
565 return true; 566 return true;
566 } 567 }
567 568
568 bool HTMLPlugInElement::shouldUsePlugin(const KURL& url, const String& mimeType, bool hasFallback, bool& useFallback) 569 bool HTMLPlugInElement::shouldUsePlugin(const KURL& url, const String& mimeType, bool hasFallback, bool& useFallback)
569 { 570 {
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
661 return openShadowRoot(); 662 return openShadowRoot();
662 } 663 }
663 664
664 void HTMLPlugInElement::lazyReattachIfNeeded() 665 void HTMLPlugInElement::lazyReattachIfNeeded()
665 { 666 {
666 if (!useFallbackContent() && !usePlaceholderContent() && needsWidgetUpdate() && layoutObject() && !isImageType()) 667 if (!useFallbackContent() && !usePlaceholderContent() && needsWidgetUpdate() && layoutObject() && !isImageType())
667 lazyReattachIfAttached(); 668 lazyReattachIfAttached();
668 } 669 }
669 670
670 } 671 }
OLDNEW
« no previous file with comments | « Source/core/frame/RemoteFrame.cpp ('k') | Source/core/layout/compositing/DeprecatedPaintLayerCompositor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698