Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1292783004: Run Cronet perf test on Cronet bot

Created:
5 years, 4 months ago by pauljensen
Modified:
4 years, 8 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Run Cronet perf test on Cronet bot Modify the bot recipe to: 1) Build quic_server and quic_client targeting the bot's native architecture 2) Build cronet_perf_test_apk targeting the device 3) Run the script to launch the benchmark

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -0 lines) Patch
M scripts/slave/recipe_modules/chromium_android/chromium_config.py View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/cronet/api.py View 1 chunk +18 lines, -0 lines 0 comments Download
M scripts/slave/recipes/cronet.py View 3 chunks +17 lines, -0 lines 2 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_armv6_builder.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_builder.json View 2 chunks +66 lines, -0 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_data_reduction_proxy_builder.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
pauljensen
Helen, PTAL. This CL feels somewhat hacky so let me know if there's a better/cleaner ...
5 years, 4 months ago (2015-08-17 14:21:18 UTC) #2
xunjieli
I think this looks right as long as it works :). Should we also upload ...
5 years, 4 months ago (2015-08-17 14:58:05 UTC) #3
xunjieli
I got the reverse tethering working by commenting out if (!session_->params().enable_insecure_quic && !original_url.SchemeIs("https")) { continue; ...
5 years, 4 months ago (2015-08-17 22:15:11 UTC) #4
xunjieli
On 2015/08/17 22:15:11, xunjieli wrote: > I got the reverse tethering working by commenting out ...
5 years ago (2015-12-14 22:09:24 UTC) #5
pauljensen
I got it running again, see https://codereview.chromium.org/1536433002/
5 years ago (2015-12-17 18:42:31 UTC) #6
xunjieli
On 2015/12/17 18:42:31, pauljensen wrote: > I got it running again, see https://codereview.chromium.org/1536433002/ That CL ...
4 years, 8 months ago (2016-03-31 14:15:11 UTC) #7
pauljensen
4 years, 8 months ago (2016-03-31 14:17:01 UTC) #8
On 2016/03/31 14:15:11, xunjieli wrote:
> On 2015/12/17 18:42:31, pauljensen wrote:
> > I got it running again, see https://codereview.chromium.org/1536433002/
> 
> That CL is landed. Can we land this too? Might need a rebase.

Ya, we should land this too.  I'll add it to my work queue.

Powered by Google App Engine
This is Rietveld 408576698