Run Cronet perf test on Cronet bot

scripts/slave/recipes/cronet.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from infra.libs.infra_types import freeze
 
 DEPS = [
+  'chromium',
   'cronet',
   'path',
   'properties',
 ]
 
 BUILDERS = freeze({
   'local_test': {
     'recipe_config': 'main_builder',
     'run_tests': True,
     'kwargs': {
@@ skipping 14 matching lines @@
     'kwargs': {
       'BUILD_CONFIG': 'Debug',
     },
     'cronet_kwargs': {
       'PERF_ID': 'android_cronet_builder_dbg',
     },
   },
   'Android Cronet Builder': {
     'recipe_config': 'main_builder',
     'run_tests': True,
+    'run_perf_tests': True,
     'kwargs': {
       'BUILD_CONFIG': 'Release',
       'REPO_NAME': 'src',
     },
     'cronet_kwargs': {
       'PERF_ID': 'android_cronet_builder',
     },
   },
   'Android Cronet ARMv6 Builder': {
     'recipe_config': 'main_builder',
@@ skipping 81 matching lines @@
   cronet_kwargs = builder_config.get('cronet_kwargs', {})
   gyp_defs = builder_config.get('gyp_defs', {})
 
   api.cronet.init_and_sync(recipe_config, kwargs, gyp_defs)
   api.cronet.build()
 
   if cronet_kwargs['PERF_ID']:
     api.cronet.sizes(cronet_kwargs['PERF_ID'])
   if builder_config['run_tests']:
     api.cronet.run_tests(kwargs['BUILD_CONFIG'])
+  if 'run_perf_tests' in builder_config and builder_config['run_perf_tests']:

[xunjieli, 2015/08/17 14:58:05]

Why do we run perf tests only on "Android Cronet Builder"? Should the other bots
with "run_tests = True" also run perf tests?

+    # Before running the perf test, build quic_server and quic_client for this
+    # host machine.
+    api.chromium.set_config('chromium')
+    # Make sure not to clobber all the Cronet binaries that were just built.
+    # Landmines are very target dependent so they'll likely be different
+    # between android and linux, so running runhooks now would make them go off.
+    # Prevent clobbering by clearing landmines that would otherwise go off
+    # when runhooks is run. It's safe to ignore landmines now because we just
+    # did a clobber build.
+    api.cronet.clear_landmines()
+    api.chromium.runhooks()

[xunjieli, 2015/08/17 14:58:05]

Suggest adding a name argument here, so it's clearer what this is for.
e.g. 
api.chromium.runhooks(name='runhooks for compiling quic server and client')

+    api.chromium.compile(targets=['quic_server', 'quic_client'])
+
+    api.cronet.run_perf_tests()
 
 
 def _sanitize_nonalpha(text):
   return ''.join(c if c.isalnum() else '_' for c in text.lower())
 
 
 def GenTests(api):
   for bot_id in BUILDERS.keys():
     props = api.properties.generic(
       buildername=bot_id,
       revision='4f4b02f6b7fa20a3a25682c457bbc8ad589c8a00',
       repository='https://chromium.googlesource.com/chromium/src',
       branch='master',
       project='src',
     )
     yield api.test(_sanitize_nonalpha(bot_id)) + props