Chromium Code Reviews| Index: scripts/slave/recipes/cronet.py |
| diff --git a/scripts/slave/recipes/cronet.py b/scripts/slave/recipes/cronet.py |
| index bbcf628f4bc2180752637be794757d2d0e89aeec..f4a54d2f5f2d230868a62fce2282f9403ba2617e 100644 |
| --- a/scripts/slave/recipes/cronet.py |
| +++ b/scripts/slave/recipes/cronet.py |
| @@ -5,6 +5,7 @@ |
| from infra.libs.infra_types import freeze |
| DEPS = [ |
| + 'chromium', |
| 'cronet', |
| 'path', |
| 'properties', |
| @@ -39,6 +40,7 @@ BUILDERS = freeze({ |
| 'Android Cronet Builder': { |
| 'recipe_config': 'main_builder', |
| 'run_tests': True, |
| + 'run_perf_tests': True, |
| 'kwargs': { |
| 'BUILD_CONFIG': 'Release', |
| 'REPO_NAME': 'src', |
| @@ -140,6 +142,21 @@ def RunSteps(api): |
| api.cronet.sizes(cronet_kwargs['PERF_ID']) |
| if builder_config['run_tests']: |
| api.cronet.run_tests(kwargs['BUILD_CONFIG']) |
| + if 'run_perf_tests' in builder_config and builder_config['run_perf_tests']: |
|
xunjieli
2015/08/17 14:58:05
Why do we run perf tests only on "Android Cronet B
|
| + # Before running the perf test, build quic_server and quic_client for this |
| + # host machine. |
| + api.chromium.set_config('chromium') |
| + # Make sure not to clobber all the Cronet binaries that were just built. |
| + # Landmines are very target dependent so they'll likely be different |
| + # between android and linux, so running runhooks now would make them go off. |
| + # Prevent clobbering by clearing landmines that would otherwise go off |
| + # when runhooks is run. It's safe to ignore landmines now because we just |
| + # did a clobber build. |
| + api.cronet.clear_landmines() |
| + api.chromium.runhooks() |
|
xunjieli
2015/08/17 14:58:05
Suggest adding a name argument here, so it's clear
|
| + api.chromium.compile(targets=['quic_server', 'quic_client']) |
| + |
| + api.cronet.run_perf_tests() |
| def _sanitize_nonalpha(text): |