Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4402)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

Issue 1292493002: Add signals to make callback more reliable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Signal hidden onPause rather than onStop Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
index 3e426661990a58e7c9365e74507822700eecacde..94964759984c6cef110b5944d8c3006b1d001cbf 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
@@ -7,6 +7,7 @@ package org.chromium.chrome.browser.customtabs;
import android.content.Intent;
import android.net.Uri;
import android.os.IBinder;
+import android.support.customtabs.CustomTabsCallback;
import android.support.customtabs.CustomTabsIntent;
import android.text.TextUtils;
import android.view.MenuItem;
@@ -223,6 +224,14 @@ public class CustomTabActivity extends ChromeActivity {
}
}
+
+ @Override
+ public void onPauseWithNative() {
+ super.onPauseWithNative();
+ CustomTabsConnection.getInstance(getApplication()).notifyNavigationEvent(
+ mSession, CustomTabsCallback.TAB_HIDDEN);
+ }
+
@Override
public void onStopWithNative() {
super.onStopWithNative();
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698