Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: content/common/sandbox_win.cc

Issue 1291553003: Print stack traces in child processes when browser tests failed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: patch 1295823002 which fixes the console coming up on Win8+ and adds regression tests Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/sandbox_win.cc
diff --git a/content/common/sandbox_win.cc b/content/common/sandbox_win.cc
index 7627865c3ed4f7a7daf6a7d3f71df6c252375bae..110edb8a6812438efa13d1d1549568dfdc6553b0 100644
--- a/content/common/sandbox_win.cc
+++ b/content/common/sandbox_win.cc
@@ -328,8 +328,8 @@ bool AddGenericPolicy(sandbox::TargetPolicy* policy) {
return false;
#endif // NDEBUG
- // Add the policy for read-only PDB file access for AddressSanitizer.
-#if defined(ADDRESS_SANITIZER)
+ // Add the policy for read-only PDB file access for stack traces.
+#if !defined(OFFICIAL_BUILD)
base::FilePath exe;
if (!PathService::Get(base::FILE_EXE, &exe))
return false;
@@ -741,12 +741,12 @@ base::Process StartSandboxedProcess(
return base::Process();
}
- if (browser_command_line.HasSwitch(switches::kEnableLogging)) {
- // If stdout/stderr point to a Windows console, these calls will
- // have no effect.
- policy->SetStdoutHandle(GetStdHandle(STD_OUTPUT_HANDLE));
- policy->SetStderrHandle(GetStdHandle(STD_ERROR_HANDLE));
- }
+#if !defined(OFFICIAL_BUILD)
+ // If stdout/stderr point to a Windows console, these calls will
+ // have no effect.
+ policy->SetStdoutHandle(GetStdHandle(STD_OUTPUT_HANDLE));
+ policy->SetStderrHandle(GetStdHandle(STD_ERROR_HANDLE));
+#endif
if (delegate) {
bool success = true;

Powered by Google App Engine
This is Rietveld 408576698